| Age | Commit message (Collapse) | Author |
|---|
|
Issue was spotted by Klocwork, and fixed by arsharma as part of
Android-ia.
Just bail out if memory allocation fails. All the callers of insert()
already handle the case.
[Emil Velikov: Split from larger patch, write commit message]
Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
|
|
Clears up gcc warning on Solaris:
common_device_name.c: In function 'pci_id_file_open':
common_device_name.c:83:17: warning: unused variable 'result' [-Wunused-variable]
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Well, almost all of them. zlib doesn't support "e" in the mode string
in gzopen() though it will silently accept and ignore it, and Solaris appears
not to support "e" in the mode string at all.
Signed-off-by: Adam Jackson <ajax@redhat.com>
|
|
This fixes the compiler warning of using the wrong type for gzgets() and
gzclose() as they want a gzFile argument, not a pointer to gzFile. The
abstraction layer pci_id_file should just abstract the full type.
Signed-off-by: Mathias Krause <mathias.krause@secunet.com>
Reviewed-by: Jeremy Huddleston <jeremyhu@apple.com>
|
|
Error: File Leak
Leaked File f
at line 272 of src/common_device_name.c in function 'populate_vendor'.
f initialized at line 204 with fopen("/usr/share/hwdata/pci.ids", "r").
[ This bug was found by the Parfait 0.5.0 bug checking tool.
For more information see http://labs.oracle.com/projects/parfait/ ]
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
Performed with: find * -type f | xargs perl -i -p -e 's{[ \t]+$}{}'
git diff -w & git diff -b show no diffs from this change
Signed-off-by: Alan Coopersmith <alan.coopersmith@oracle.com>
|
|
src/common_device_name.c:59: warning: function declaration isn't a prototype
src/common_device_name.c: In function 'pci_id_file_open':
src/common_device_name.c:59: warning: old-style function definition
|
|
|
|
Add an option to build with zlib support so we can find
vendor/device information if the pci.ids file is gzipped.
Signed-off-by: Julien Cristau <jcristau@debian.org>
|
|
|
|
|
|
PCIIDS_PATH should always be provided by configure.ac and config.h.
|
|
could not be opened. Thanks to Aaron Plattner for reporting this. Fix a
couple possible memory leaks in the same function.
|
|
|
|
Bump version to 0.3.0.
Replace pci_get_name with pci_get_strings. This function matches the
functionality provided by the Xorg scanpci module almost identically.
|
|
|
