| Age | Commit message (Collapse) | Author |
|---|
|
Update argument types for sprint_frac_value to reflect how big they
actually are so that GCC doesn't think it needs a larger buffer than
necessary.
Message-ID: <ZeS1i5u_OziWpApt@jupiter.tail36e24.ts.net>
|
|
This makes GCC happy.
Message-ID: <20231229212105.858759-6-flaviocruz@gmail.com>
|
|
function declarations.
Most of the changes land in one of these buckets:
* Removed unused declarations.
* Used (void) to represent no parameters instead of () which means an
undeterminate number of parameters.
* Included missing header files whenever necessary (stdlib.h,
sys/mman.h, etc)
* Typedefed function pointers to be able to fully declare the parameter
types.
* Added declarations of library functions that are used elsewhere
(example is libps/ps.h).
* Made functions static whenever they are only used in that file.
* Forwarded declarations of some methods that were made static.
Message-Id: <ZDD1o7/tVYeZew+G@jupiter.tail36e24.ts.net>
|
|
comm was not recognized by Hurd's ps as a format spec, but is required by
POSIX to display the command name (like "exe", but without the full path).
|
|
* libps/Makefile (SRCS): Add ../utils/msgids.c.
(../utils/msgids-CPPFLAGS): Add DATADIR macro.
* libps/spec.c: Include "../utils/msgids.h".
(get_rpc_name): Implement with msgid_info.
* utils/msgids.c (parse_opt): Move end code to ...
(msgids_scan_std): ... new function.
* utils/msgids.h (msgids_scan_std): New prototype.
* utils/ps.c (main): Call msgids_scan_std.
|
|
by adding proc_set/get_exe to the proc server, making
exec call proc_set_exe, and libps call proc_get_exe. procfs can then just
retrieve the information to make the "exe" symlink.
* hurd/process.defs (proc_set_exe, proc_get_exe): New RPCs.
* hurd/process_request.defs: Likewise.
* hurd/process_reply.defs: Add skips for proc_set_exe and proc_get_exe RPCs.
* proc/proc.h (struct proc): Add `exe' field.
* proc/info.c (S_proc_set_exe, S_proc_get_exe): New functions.
* proc/mgt.c (process_has_exited): Free p->exe.
(S_proc_child): Duplicate parent `exe' into child's `exe'.
* exec/exec.c (do_exec): Call proc_set_exe when a filename is available.
* libps/ps.h (struct proc_stat): Add `exe_vm_alloced', `exe', and `exe_len'
field.
(PSTAT_EXE): New macro.
(PSTAT_USER_BASE): Change value to make room.
(proc_stat_exe, proc_stat_exe_len): New macros.
* libps/procstat.c (proc_stat_set_flags): Handle PSTAT_EXE case by calling
proc_get_exe.
* libps/spec.c (ps_get_exe): New function.
(ps_exe_getter): New structure.
(ps_fmt_spec): Add "Exe" specification.
* procfs/process.c (process_file_symlink_make_node, process_file_gc_exe): New
functions.
(procfs_dir_entry): Add "exe" entry.
* startup/startup.c (launch_core_servers): Set exe paths for startup, auth,
proc, and fs servers.
(frob_kernel_process): Set exe path for kernel task.
(S_startup_essential_task): Set exe path for exec server.
|
|
* boot/boot.c: Replace bcopy with memcpy or memmove as appropriate.
* exec/hashexec.c: Likewise.
* libps/proclist.c: Likewise, but also fix the amount of data copied.
* libps/procstat.c: Likewise.
* libps/spec.c: Likewise.
* libshouldbeinlibc/cacheq.c: Likewise.
* libshouldbeinlibc/idvec.c: Likewise.
* libshouldbeinlibc/timefmt.c: Likewise.
|
|
Our variants print stack traces on failures. This will make locating
errors much easier.
|
|
* libps/spec.c (ps_cmp_times): Actually compare tv_usec fields of tv1
and tv2.
|
|
For reference, this patch was created using the following semantic
patch, and then manually applying the change in all functions
containing nested functions, as those are not supported by Coccinelle.
@@
expression A, B;
@@
- bzero (A, B)
+ memset (A, 0, B)
* auth/auth.c: Replace `bzero' with `memset'.
* boot/boot.c: Likewise.
* defpager/defpager.c: Likewise.
* exec/exec.c: Likewise. Also, drop `safe_bzero' and just use
`hurd_safe_memset' directly.
* ext2fs/ext2fs.c: Likewise.
* ext2fs/getblk.c: Likewise.
* ext2fs/pager.c: Likewise.
* fatfs/pager.c: Likewise.
* ftpfs/dir.c: Likewise.
* ftpfs/netfs.c: Likewise.
* isofs/inode.c: Likewise.
* isofs/pager.c: Likewise.
* libdiskfs/file-getfh.c: Likewise.
* libdiskfs/file-statfs.c: Likewise.
* libfshelp/fetch-root.c: Likewise.
* libfshelp/start-translator.c: Likewise.
* libftpconn/create.c: Likewise.
* libftpconn/open.c: Likewise.
* libftpconn/unix.c: Likewise.
* libpipe/pipe.c: Likewise.
* libps/procstat.c: Likewise.
* libps/spec.c: Likewise.
* libshouldbeinlibc/cacheq.c: Likewise.
* libshouldbeinlibc/idvec.c: Likewise.
* libshouldbeinlibc/ugids.c: Likewise.
* libstore/argp.c: Likewise.
* libstore/enc.c: Likewise.
* libstore/kids.c: Likewise.
* libthreads/alpha/thread.c: Likewise.
* libtreefs/fsys.c: Likewise.
* libtrivfs/file-statfs.c: Likewise.
* mach-defpager/default_pager.c: Likewise.
* pfinet/glue-include/asm/uaccess.h: Likewise.
* pfinet/io-ops.c: Likewise.
* pfinet/options.c: Likewise.
* pfinet/socket.c: Likewise.
* pfinet/timer-emul.c: Likewise.
* pflocal/io.c: Likewise.
* startup/startup.c: Likewise.
* storeio/storeio.c: Likewise.
* sutils/fstab.c: Likewise.
* usermux/usermux.c: Likewise.
* utils/fakeauth.c: Likewise.
* utils/frobauth.c: Likewise.
* utils/login.c: Likewise.
* utils/x.c: Likewise.
|
|
Introduce PSTAT_TIMES to force the retrieval of both PSTAT_TASK_BASIC
and PSTAT_THREAD_BASIC. Task basic info contain the user and system
times of terminated threads which the code wrongly assumes is always
present along with process info.
* libps/procstat.c (add_preconditions): Set both PSTAT_TASK_BASIC and
PSTAT_THREAD_BASIC as preconditions for PSTAT_TIMES.
(summarize_thread_basic_info): Add terminated threads times only if
task basic info are available.
(set_procinfo_flags): Provide summarize_thread_basic_info with flags of
available info.
(proc_stat_set_flags): Set PSTAT_TIMES as available if it was needed and
any of PSTAT_TASK_BASIC or PSTAT_THREAD_BASIC could be fetched.
* libps/ps.h (PSTAT_TIMES): New macro.
* libps/spec.c (ps_get_usr_time): Indicate the getter needs PSTAT_TIMES
instead of PSTAT_THREAD_BASIC.
(ps_sys_time_getter): Likewise.
(ps_tot_time_getter): Likewise.
|
|
Found using the Clang Static Analyzer.
* libps/spec.c (fprint_frac_value): Fix computation of value_len.
|
|
* libps/spec.c (ps_emit_user_name): Do not dereference pw when it is NULL,
dereference u instead.
|
|
Add (and implement) a proc RPC to obtain the number of Mach ports used
by the target task.
Add infrastructure in libps to read this information.
* hurd/process.defs (proc_getnports): New RPC.
* hurd/process_request.defs (proc_getnports_request): New RPC.
* libps/procstat.c (proc_stat_set_flags): Call proc_getnports RPC if
needed.
* libps/ps.h (proc_stat): New `num_ports' field.
(PSTAT_NUM_PORTS): New macro.
(proc_stat_num_ports): New macro.
* libps/spec.c (ps_get_num_ports): New function.
(ps_num_ports_getter): New variable.
(specs): New entry for `ps_num_ports_getter'.
* proc/info.c (S_proc_getnports): New function.
|
|
* spec.c (sprint_frac_value): Added case for values between 1000 and
1023. Make VALUE, FRAC size_t's and return a value of type size_t.
(ps_emit_nice_int): Removed function. Replaced by ...
(ps_emit_nice_size_t): ... this. New Function.
(ps_cmp_size_ts): New function.
(ps_vsize_getter): Return a size_t instead of an int.
(ps_rsize_getter): Likewise.
(ps_get_rmem_frac): MEM_SIZE is now a size_t.
(specs): Use ps_emit_nice_size_t instead of ps_emit_nice_int and use
ps_cmp_size_ts instead of ps_cmp_ints for RSize and VSize.
|
|
* spec.c (ps_emit_wait): Remove local extern decls for functions
actually defined static.
|
|
* ps.h (PSTAT_ENV): New macro.
(struct proc_stat): New members `env', `env_len', `env_vm_alloced'.
(proc_stat_env, proc_stat_env_len): New accessor macros.
(PSTAT_USER_BASE): Increase value to leave more room for additions.
* procstat.c (proc_stat_set_flags): Handle environment.
(_proc_stat_free): Likewise.
* spec.c (ps_get_env, ps_env_getter): New function and constant.
(specs): New spec "Env" using ps_env_getter and ps_emit_args.
|
|
* spec.c (ps_emit_past_time, ps_emit_minutes): Fix return type of
getter fn (int to void).
* spec.c (ps_get_start_time, ps_start_time_getter): New function and
constant to report task_basic_info.creation_time time stamp via
"start_time" spec.
(specs): Add "Start" fmt for it.
|
|
Provide slightly better abbreviations for various port types.
|
|
New function.
(specs):
Use ps_nominal_string for `Args' and `Arg0' fields.
(ps_emit_args, ps_emit_string):
Use `-' for empty values.
|
|
Interpret PS_FMT_FIELD_COLON_MOD flag to mean `print zero as "-"'.
|
|
|
|
|
|
(specs_add_alias): Use a linked list of ps_fmt_spec_blocks instead of
reallocing a block of specs.
(ps_fmt_specs_find): Change searching accordingly.
|
|
|
|
(specs_add_alias): Pass on flags field.
(specs): Add precision & flags fields.
(FG): New macro.
(ps_emit_*): Take FIELD argument instead of WIDTH.
|
|
(ps_emit_seconds): Use new args to fmt_seconds.
(ps_emit_minutes): Use new args to fmt_minutes.
|
|
attributes (that are likely to be noise).
|
|
|
|
(specv_find, specs_add_alias): New functions.
Get rid of mega typedefs, and just use structure pointers like other hurd
libraries. Other misc cleanups.
|
|
|
|
(ps_emit_wait): New function.
(ps_emit_string, ps_emit_string0): Use ps_stream_write_trunc_field.
(ps_get_wait): Renamed from ps_get_rpc; calling convention changed.
(ps_wait_getter): Renamed from ps_rpc_getter & contents changed accord.
(get_syscall_name, get_rpc_name): New stub functions.
|
|
ps_owner_getter, ps_owner_uid_getter, ps_ppid_getter, ps_pgrp_getter,
ps_session_getter, ps_login_col_getter, ps_num_threads_getter,
ps_args_getter, ps_state_getter, ps_rpc_getter, ps_vsize_getter,
ps_rsize_getter, ps_cur_priority_getter, ps_base_priority_getter,
ps_max_priority_getter, ps_usr_time_getter, ps_sys_time_getter,
ps_tot_time_getter, ps_rmem_frac_getter, ps_cpu_frac_getter,
ps_sleep_getter, ps_susp_count_getter, ps_proc_susp_count_getter,
ps_thread_susp_count_getter, ps_tty_getter, ps_page_faults_getter,
ps_cow_faults_getter, ps_pageins_getter, ps_msgs_sent_getter,
ps_msgs_rcvd_getter, ps_zero_fills_getter):
Make const.
|
|
display if any thread isn't suspended.
(ps_get_usr_time, ps_get_sys_time, ps_get_tot_time):
Return a struct timeval instead of mach time_value_t.
(ps_cmp_times): New function.
(specs): Rearrange to use new field layout.
(ps_fmt_specs_find): Renamed from find_ps_fmt_spec; now uses a struct
ps_fmt_specs instead of an array of specs.
(specs): Renamed from ps_std_fmt_specs;
(ps_std_fmt_specs): Now of type struct ps_fmt_specs, pointing to specs.
(ps_emit_seconds, ps_emit_minutes): Use timefmt functions.
(append_fraction, sprint_long_time, ps_emit_nice_seconds): Deleted.
Include <timefmt.h>.
|
|
Write `-' when the value is 0, rather than mangling the output.
(ps_emit_uid): Use an int uid, and emit "-" for none.
(ps_emit_uname, ps_cmp_uids, ps_cmp_unames, ps_nominal_user):
Handle NULL users.
(ps_owner_uid_getter): New variable.
(ps_get_owner_uid, ps_nominal_uid): New functions.
(ps_std_fmt_specs): Make "UID" use owner_uid rather than owner.
(own_uid): New variable (was function local).
|
|
ps_emit_percent, ps_emit_num_blocks, ps_emit_nice_int,
ps_emit_nice_seconds, ps_emit_seconds, ps_emit_uid, ps_emit_uname,
ps_emit_string0, ps_emit_string, ps_emit_tty_name, ps_emit_state):
Use new STREAM parameter instead of old one and count.
Use new function names.
|
|
ps_get_cur_priority):
Get this info using PSTAT_THREAD_BASIC instead of PSTAT_THREAD_SCHED.
|
|
(ps_get_rpc): New function.
(ps_std_fmt_specs): Add "RPC" entry.
(ps_emit_nz_int): New function.
(ps_ppid_getter, ps_pgrp_getter, ps_session_getter, ps_login_col_getter):
Use PSTAT_PROC_INFO, not PSTAT_INFO.
(ps_get_ppid, ps_get_pgrp, ps_get_session, ps_get_login_col):
Use proc_stat_proc_info, not proc_stat_info.
(ps_vsize_getter, ps_rsize_getter, ps_rmem_frac_getter,
ps_proc_susp_count_getter): Use PSTAT_TASK_BASIC, not PSTAT_INFO.
(ps_get_vsize, ps_get_rsize, ps_get_rmem_frac, ps_get_proc_susp_count):
Use proc_stat_task_basic_info, not proc_stat_info.
(ps_cur_priority_getter, ps_base_priority_getter, ps_max_priority_getter):
Use PSTAT_THREAD_SCHED, not PSTAT_THREAD_INFO.
(ps_usr_time_getter, ps_sys_time_getter, ps_tot_time_getter,
ps_cpu_frac_getter, ps_sleep_getter):
Use PSTAT_THREAD_BASIC, not PSTAT_THREAD_INFO.
|
|
(state_shadows): New variable.
(ps_emit_state): Use the state_shadows list to turn off some states.
|
|
(ps_nominal_zint, ps_nominal_user, ps_nominal_pri, ps_nominal_nth):
Possible nominal funs.
|
|
TSusp (thread suspend count) output specs.
|
|
sleeping or idle threads' status (as that's presumably the signal thread).
(ps_emit_tty_name): Move guts into into ps_tty_short_name.
Tighten up types used (i.e., don't use int for everything).
|
|
one. Change MsgsIn and MsgsOut to MsgIn and MsgOut.
|
|
(ps_emit_num_blocks): Use int format for int arg.
(sprint_frac_value): Likewise.
|
|
|
|
compatible way (that is, 20 .. -20 instead of 0 .. 24). Use this instead
of ps_emit_int to print all priority fields. This also increases the min
field width for them to 3.
|
|
Use ps_user_t routines instead of querying passwd or getting the owner from
ps->info.
Increase the width of the user name field to 8.
|
|
|
