diff options
author | Robin Gareus <robin@gareus.org> | 2018-07-24 21:35:14 +0200 |
---|---|---|
committer | Robin Gareus <robin@gareus.org> | 2018-07-24 23:22:21 +0200 |
commit | 203c6546c198053c3a5fc93a6c515424b22e465c (patch) | |
tree | ab74b85632ab031eec02327bf5dd3561dee41bb6 /gtk2_ardour/generic_pluginui.cc | |
parent | 938b2422e3a27a94b0b084b40663255c5457eba1 (diff) |
GUI tweaks for unset midi banks.
Some MIDNAM files use Patch-Banks that do *not* have a common midi bank
(CC0, CC32) but the Patchbank is instead just a collection of patches.
There may be more than 127 patches in a patch-bank and each of those
may be in a different midi-bank (e.g. Roland SC-88 Pro).
Midnams like these are now properly supported via dropdowns (in the
patch add/modify dialog and timeline), but ignored by the grid
(patch-widget). More work is needed.
Diffstat (limited to 'gtk2_ardour/generic_pluginui.cc')
-rw-r--r-- | gtk2_ardour/generic_pluginui.cc | 1 |
1 files changed, 0 insertions, 1 deletions
diff --git a/gtk2_ardour/generic_pluginui.cc b/gtk2_ardour/generic_pluginui.cc index 1e48986a28..055129b704 100644 --- a/gtk2_ardour/generic_pluginui.cc +++ b/gtk2_ardour/generic_pluginui.cc @@ -732,7 +732,6 @@ GenericPluginUI::midi_refill_patches () for (MIDI::Name::PatchNameList::const_iterator j = patches.begin(); j != patches.end(); ++j) { const std::string pgm = (*j)->name (); MIDI::Name::PatchPrimaryKey const& key = (*j)->patch_primary_key (); - assert ((*i)->number () == key.bank()); const uint32_t bp = (key.bank() << 7) | key.program(); midi_pgmsel[chn]->AddMenuElem (MenuElemNoMnemonic (pgm, sigc::bind (sigc::mem_fun (*this, &GenericPluginUI::midi_bank_patch_select), chn, bp))); pgm_names[bp] = pgm; |