libports: work around bugs in server termination

Most servers use ports_manage_port_operations_multithread to process
requests and terminate when it returns. Since many of them don't detach
before shutting down, a client may receive an error if its request
arrived while the server is shutting down. Prevent those spurious errors
by forcing ports_manage_port_operations_multithread not to return.

* libports/manage-multithread.c
(ports_manage_port_operations_multithread): Force global_timeout to 0.

1 files changed, 6 insertions, 0 deletions

diff --git a/libports/manage-multithread.c b/libports/manage-multithread.c
index 64e442fe..2067cbaa 100644
--- a/libports/manage-multithread.c
+++ b/libports/manage-multithread.c
@@ -236,5 +236,11 @@ ports_manage_port_operations_multithread (struct port_bucket *bucket,
       return NULL;
     }
 
+  /* XXX It is currently unsafe for most servers to terminate based on
+     inactivity because a request may arrive after a server has started
+     shutting down, causing the client to receive an error.  Prevent the
+     master thread from going away.  */
+  global_timeout = 0;
+
   thread_function ((void *) 1);
 }