summaryrefslogtreecommitdiff
path: root/libs/ardour
AgeCommit message (Collapse)Author
2020-05-13DiskReader: improve commentPaul Davis
2020-05-13DiskReader: always reset file_sample[AUDIO] after an overwritePaul Davis
In theory we only need to do this if the use of a loop for a given overwrite differs from the previous refill or overwrite. However, keeping track of this is hard, and this way effectively enforces the notion that if we do the arithmetic correct, for cases where there's no change in the use of a loop location, this ends up being a no-op (i.e. we are resetting it back to its current value)
2020-05-13avoid off-by-one error when overwriting w/loopPaul Davis
2020-05-13update DiskReader loop delick objects when loop changesPaul Davis
2020-05-13reinstate Session::loop_changing to avoid problems when locating to start of ↵Paul Davis
loop for loop play
2020-05-13Fix crash when closing session with VCA slaved soloRobin Gareus
Session::destroy() calls drop_references(), which leads to InternalSend::send_from_going_away() calling InternalSend::propagate_solo(). This looks up the SoloControl to test soloed_by_others(), incl. and VCA maters. Those VCAs however may already have been destroyed, and (weak pointer) _master.lock() fails.
2020-05-13Set timecode format from active master onlyRobin Gareus
2020-05-12essentially a no-op to just make conditional clearer more explicitPaul Davis
2020-05-12find a different way to NOT unset play loop when locating to start of loopPaul Davis
2020-05-12NO-OP: remove commented linePaul Davis
2020-05-12DiskReader::overwrite_existing_audio() now only overwrites data that would ↵Paul Davis
be read There's no need to fill the whole buffer, because we do not consider the whole buffer readable. This uses the recently-added PlaybackBuffer::overwritable_at() API to compute the correct amount of data to overwrite
2020-05-12NO-OP: expand comments for DiskReader::audio_read() parametersPaul Davis
2020-05-12after an overwrite with the loop location set, reset the next sample to be readPaul Davis
2020-05-12remove Session::loop_changingPaul Davis
Since we now (correctly) do not locate for loop changes, this member is unnecessary
2020-05-12remove #ifdef'ed codePaul Davis
2020-05-12restore mistakenly remove condition for locatingPaul Davis
2020-05-12NO-OP: remove newline in function definitionPaul Davis
2020-05-12remove debug/information messagePaul Davis
2020-05-12As in previous commit, never locate because of loop handlingPaul Davis
2020-05-12We use seamless looping always now. Never any need to locate for loop changesPaul Davis
2020-05-12make conditional logic fully explicitPaul Davis
2020-05-12LocateRoll session events should always roll-after locatePaul Davis
Don't rely on ev->locate_transport_disposition
2020-05-12trivial reorder of variable assigmentPaul Davis
2020-05-12Don't bother even checking let alone doing internal seeks for zero distancesPaul Davis
2020-05-12use more standard mechanism for "squishing" start of audio read into loop rangePaul Davis
2020-05-12new mechanism to refill pre-loop buffer when loop changes (used for xfading ↵Paul Davis
loop ends)
2020-05-12Use better method call to determine rolling status when loop is changedPaul Davis
2020-05-12remove unused variablePaul Davis
2020-05-12remove Route::reload_loop() and derivativesPaul Davis
Replacement to follow in subsequent commit
2020-05-12use const; style guide (no spaces around conditional parenthesis)Paul Davis
2020-05-12NO-OP: style guide issues (always use braces; no spaces around conditional ↵Paul Davis
parenthesis)
2020-05-12Fix spacing of engine-delta displayRobin Gareus
2020-05-12Use byte-offset when reading size at ringbuffer boundaryRobin Gareus
This likely fixes https://github.com/sfztools/sfizz/issues/221
2020-05-12Consolidate delta-string format, avoid markupRobin Gareus
2020-05-12Fix MTC delta reportRobin Gareus
This amends a6ffc6213b92735034bd7dc39638e926bca219da. apply the offset before the DLL.
2020-05-11Transport Masters dialog: use delta symbol in all delta_strings (libardour ↵Ben Loftis
tweak)
2020-05-11Slave delta display tweaksRobin Gareus
* use left-aligned sign symbol with "sample" unit. When the delta value jitters in decimal places (e.g. MTC) it's otherwise no possible to discern + vs -. * Use white text by default (not green)
2020-05-11Fix TCM requiring port-reconnect when engine restartsRobin Gareus
An engine restart sends dis-connect messages for the reverse port-mapping (after making the connection): Connect: system:midi_capture_41a56f90 -> ardour:MTC in Connect: system:capture_1 -> ardour:LTC in DisConnect: ardour:MTC in -> system:midi_capture_41a56f90 DisConnect: ardour:LTC in -> system:capture_1 This lead to TransportMaster being marked as inactive. This is likely an issue that should be fixed elsewhere, but in case of JACK, we likely do not have control over this.
2020-05-11Fix MTC latency compensationRobin Gareus
Offset the detected timecode instead of the detection time. The latter is used by the DLL and later also used to calculate delta times which lead to a constant offset.
2020-05-11Fix MTC slave port latencyRobin Gareus
2020-05-10LTC: sync-lock is only relevant when clock is syncedRobin Gareus
2020-05-09Fix initial sync to external time sourceRobin Gareus
TransportMasterStart needs to be set when this cycle's delta can reach _remaining_latency_preroll. This allows to directly catch the master-position and start rolling without initial vari-speed.
2020-05-09Update LTC reader port latency on connection changeRobin Gareus
This mechanism adds infrastructure that can later also be used for MTC and MIDIClock. PS. The LTC Generator port's latency is queried after the port is created, and later kept in sync via LatencyUpdated signal.
2020-05-09Fix subtle bug breaking vari-speed (from d9caa7fd9a55e)Robin Gareus
2020-05-09LTC Generator: prefer LatencyUpdated signalRobin Gareus
2020-05-08LTC Slave: subscribe to LatencyUpdated signalRobin Gareus
This uses a recently introduce Signal instead of the generic GraphReordered, which was used in the past since it usually happened after the latency was changed.
2020-05-08NO-OP: clang-format/whitespaceRobin Gareus
2020-05-08Fix aux-send solo propagationRobin Gareus
* Do not allow new send to change implicit solo (no propagation) * Propagate changes to due aux-send removal upstream to tracks or busses connected to the source route. * Forward solo-isolate
2020-05-08Experiment: propagate solo-state with internal-sendsRobin Gareus
So far internal-sends were explicitly special-cased, and implicit solo-state only was only forwarded for direct up/down-stream connections. ...and nobody can remember why :) This restriction is removed, so far mainly with commenting-out code, as experiment. Internal sends are not only more convenient, but also required in cases where direct connections result in ambiguous latency.
2020-05-08Fix 6afcb350c5, internal backends don't report externally_connected()Robin Gareus