Age | Commit message (Collapse) | Author | |
---|---|---|---|
2017-04-19 | Use PBD::to_string in AutomationTimeAxis instead of boost::lexical_cast and ↵ | Tim Mayberry | |
string_compose | |||
2017-04-19 | Use PBD::to_string() from pbd/string_convert.h in VCATimeAxisView | Tim Mayberry | |
2017-04-19 | Use PBD::to_string from pbd/string_convert.h in VCAMasterStrip class | Tim Mayberry | |
2017-04-19 | Use PBD::to_string from pbd/string_convert.h in SoundFileBox class | Tim Mayberry | |
Numeric formatting is equivalent. | |||
2017-04-19 | Use PBD::to_string from pbd/string_convert.h in RouteTimeAxis | Tim Mayberry | |
Numeric formatting is equivalent as LC_NUMERIC=C in global C++ locale | |||
2017-04-19 | Use PBD::to_string from pbd/string_convert.h in MixerStrip class | Tim Mayberry | |
The numeric formatting is equivalent. Even though this string is being used in the UI as a label I think this is another case where we don't want a localized numeric string, which would only be relevant with a track count >=1000. | |||
2017-04-19 | Use PBD::to_string from pbd/string_convert.h in MeterStrip class | Tim Mayberry | |
The numeric formatting is equivalent. The string is being used in a label so it could be argued that we want localized numeric formatting in this case, but as it is only relevant if we have >=1000 meter strip keep it the same for now. | |||
2017-04-19 | Use PBD::to_string from pbd/string_convert.h in ExportTimespanSelector | Tim Mayberry | |
The C++ global locale is currently set to LC_NUMERIC=C by the first instance of LocaleGuard so this change means numeric formatting is equivalent. As the string is being used to construct a label, perhaps we do want to generate localized numeric formatting in this case. Anyway keep it the same for now. | |||
2017-04-19 | Use PBD::to_string() from pbd/string_convert.h in ControlSlaveUI | Tim Mayberry | |
The numeric formatting is equivalent. | |||
2017-04-19 | Use PBD::to_string instead of std::ostream when setting up video server url | Tim Mayberry | |
To avoid issues with locales that use grouping/thousands separators. | |||
2017-04-19 | Use PBD::to_string to convert period count in EngineControl class | Tim Mayberry | |
The functionality is the same so might as well use it. | |||
2017-04-19 | Use PBD::to_string to convert bufsize to string in EngineControl class | Tim Mayberry | |
string_compose uses std::ostream/stringstream which will insert thousands separators in some locales. This was not a problem when LocaleGuard set the global C++ locale to "C" | |||
2017-04-19 | Use PBD::string_to functions in VideoUtils::video_query_info | Tim Mayberry | |
LocaleGuard is in use so float <=> string conversions must be expected in C locale format | |||
2017-04-19 | Use snprintf instead of std::stringstream when converting color values to ↵ | Tim Mayberry | |
strings std::ostream/stringstream will use the current locale to determine the numeric formatting. If the locale uses grouping then thousands separators will be inserted in the output which produces an invalid color string in UIConfiguration::reset_gtk_theme() and when converting colors to strings in UIConfiguration::store_color_theme() This has not been a problem so far because it appears that LocaleGuard does not reset the LC_NUMERIC value for the global C++ locale. So if a LocaleGuard is created at any time before these functions are called(even if it goes out of scope) the numeric formatting used by std::streams will use the "C" locale formatting facets. | |||
2017-04-19 | Use PBD::string_to<bool> in MidiTimeAxisView class | Tim Mayberry | |
As the conversion was performed with PBD::to_string | |||
2017-04-19 | Use PBD::string_to<bool> in RouteTimeAxisView class | Tim Mayberry | |
As they were converted from bool to string using PBD::to_string | |||
2017-04-19 | Remove conditional checks that are always true in RouteTimeAxisView class | Tim Mayberry | |
2017-04-19 | Use AxisView::get/set_gui_property API in RouteTimeAxisView class | Tim Mayberry | |
2017-04-19 | Use AxisView::get/set_gui_property API in MixerStrip class | Tim Mayberry | |
2017-04-19 | Use AxisView::get_gui_property API in AutomationTimeAxis class | Tim Mayberry | |
2017-04-19 | Use AxisView::get_gui_property in AudioRegionView class | Tim Mayberry | |
2017-04-19 | Use AxisView::get_gui_property API in TimeAxisView class | Tim Mayberry | |
2017-04-19 | Use AxisView::get_gui_property API in AxisView class | Tim Mayberry | |
2017-04-19 | Add AxisView::get_gui_property method, use PBD::string_to<T> for string ↵ | Tim Mayberry | |
conversion | |||
2017-04-19 | Use PBD::to_string to convert non-string types in AxisView::set_gui_property | Tim Mayberry | |
2017-04-19 | Let AxisView::set_gui_property perform type conversion in ↵ | Tim Mayberry | |
TimeAxisView::set_height | |||
2017-04-19 | Use XMLNode::get_property in AudioClock class | Tim Mayberry | |
2017-04-19 | Use XMLNode::get/set_property API in VideoTimeLine class | Tim Mayberry | |
2017-04-19 | Use XMLNode::set_property API in VideoMonitor class | Tim Mayberry | |
2017-04-19 | Use XMLNode::set_property API in UIConfiguration class | Tim Mayberry | |
2017-04-19 | Use XMLNode::get/set_property API in SelectionMemento class | Tim Mayberry | |
2017-04-19 | Use XMLNode::get/set_property API in Selection class | Tim Mayberry | |
There were many possible value truncations occuring and some precision loss with the double conversions. | |||
2017-04-19 | Use XMLNode::get/set_property API in ProcessorBox and ProcessorWindowProxy ↵ | Tim Mayberry | |
classes | |||
2017-04-19 | Use XMLNode::get/set_property API in ProcessorBox class | Tim Mayberry | |
2017-04-19 | Use XMLNode::get/set_property API in MeterBridge class | Tim Mayberry | |
2017-04-19 | Use XMLNode::set_property API in LuaInstance class | Tim Mayberry | |
Didn't seem worth converting from XMLNode::property API to XMLNode::get_property and there may be some ordering issues. | |||
2017-04-19 | Use XMLNode::get/set_property API in LocationUI class | Tim Mayberry | |
2017-04-19 | Use XMLNode::get/set_property API in Keyboard class | Tim Mayberry | |
2017-04-19 | Use XMLNode::get_property API in AutomationTimeAxis class | Tim Mayberry | |
2017-04-19 | Use XMLNode::set_property API in GUIObject class | Tim Mayberry | |
2017-04-19 | Use XMLNode::get/set_property in ExportVideoDialog class | Tim Mayberry | |
2017-04-19 | Use XMLNode::get/set_property API in EditorRulers class | Tim Mayberry | |
2017-04-19 | Use XMLNode::get/set_property API in EditorRegions class | Tim Mayberry | |
2017-04-19 | Use XMLNode::set_property API in ARDOUR_UI class | Tim Mayberry | |
2017-04-19 | Use XMLNode::get/set_property API in ARDOUR_UI class | Tim Mayberry | |
2017-04-19 | Add AudioClock::on() method as convenience method for serialization | Tim Mayberry | |
2017-04-19 | Use XMLNode::get/set_property API in Mixer_UI class | Tim Mayberry | |
2017-04-19 | Remove unused header include in video_timeline.cc | Tim Mayberry | |
2017-04-19 | Use XMLNode::get/set_property API in Editor class | Tim Mayberry | |
2017-04-19 | Use XMLNode::get/set_property API in EngineDialog class | Tim Mayberry | |
Fixes many of the type conversions but I doubt any would have been an issue. LocaleGuard is no longer necessary |