summaryrefslogtreecommitdiff
path: root/gtk2_ardour/editor_ops.cc
AgeCommit message (Collapse)Author
2020-01-18Session::request_locate() takes a tri-valued second argument for ↵Paul Davis
"roll-after-locate" This allows callers to defer logic about auto-play/current rolling state and more to TransportFSM where it can be cnentralized and is less ambiguous
2019-12-14First batch of MessageDialog replacementsRobin Gareus
2019-11-26Reset paste-count, paste-offset on undo/redoRobin Gareus
This fixes an workflow edge-case when undoing a paste in order to paste at a different location on the same track or automation lane. After undo, any accumulated paste-offset needs to be reset
2019-09-17Correctly handle Zoom > Edit-point > MouseRobin Gareus
Previously this failed if the event was initiated outside of the canvas (e.g. Zoom buttons). This also fixes a special case of Zooming to an edit-point at zero.
2019-09-03Fix mute toggle actions when mute is automatedRobin Gareus
Track menu, as well as mixer-shortcut to set/unset mute of selected tracks needs to send a start_touch() event, otherwise the change is not effective.
2019-08-30Move StripSilenceDialog XML to dedicated functionNikolaus Gullotta
This moves the Session::add_extra_xml() call out of editor_ops.cc and moves it to its own class method StripSilenceDialog::finished()
2019-08-30Add settings retention to StripSilenceDialogNikolaus Gullotta
StripSilenceDialog will now retain its threshold, minimum length, and fade length values from run to run. This is done via Session::add_extra_xml() and recalled during the construction of StripSilenceDialog via Session::extra_xml()
2019-08-03Update GPL boilerplate and (C)Robin Gareus
Copyright-holder and year information is extracted from git log. git history begins in 2005. So (C) from 1998..2005 is lost. Also some (C) assignment of commits where the committer didn't use --author.
2019-08-01(Source List) Implement insert-region action... now uses the Source List.Ben Loftis
2019-08-01(Source List) Recover Regions feature: WIPBen Loftis
2019-08-01(Source List) Region Tags (gtk2 part)Ben Loftis
2019-05-27Fix crash when deleting selected region-view in ripple mode #7764Robin Gareus
Changing the playlist (remove_region) invalidates selection and unsets `clicked_regionview`. The region to operate on needs to be stored for later use.
2019-04-13NO-OP: whitespaceRobin Gareus
This fixes mostly <tab> after <space> and similar <tab> not used for indenting as well as some related code alignment issues.
2019-03-19Update GUI, use Session::playlists() getter (2/2)Robin Gareus
2019-03-07Fix thinko: if the entered_regionview is already part of the selection, do ↵Ben Loftis
not treat it as a special case when splitting.
2019-02-12Session-range behavior (gtk2 part)Ben Loftis
* Both the session-start and session-end point should follow the is-free option * Rename the end-is-free option to session-range-is-free, to reflect that change * This fixes the problem: recording before the start marker would move the Start, even if the user had already fixed the End marker.
2019-02-12Selection-after-split behavior (gtk2 part)Ben Loftis
* When splitting in MouseObject, entered_region should get priority over selected regions. This fixes the unexpected case where you try to split an unselected a region, but a) nothing happens OR b) some other region (maybe off-screen) is split * Range mode now has its own option for splits, which can be: Clear: the selection is cleared. Preserve: the selection is left as-is. (default) Force: all the regions that resulted from the split are selected (forcing a tool change). * Un-hid the additional config options to select only the regions BEFORE or AFTER a split. * Note: splits made with Cut Tool should be unaffected by these changes.
2018-12-28Observe preference to prompt for names when adding range markersAlex Pilon
2018-11-28NO-OP: Clarify function nameRobin Gareus
2018-11-28Use central method to check for engine where requiredRobin Gareus
These are generally places where tracks/busses are created or port connections change.
2018-11-27GUI limitation: Require engine to add/remove tracks/bussesRobin Gareus
2018-10-05move away from "sync source" conceptsPaul Davis
2018-10-02Fix weird behavior in playhead_x_to_grid: use return value from snap_to_grid.Ben Loftis
2018-10-02More correct fix for 8bfbef4: the check was already there; just needed to ↵Ben Loftis
set the dirty flag.
2018-10-02Fix deadlock when no region boundaries are selected in the Snap prefs.Ben Loftis
2018-08-24use new CoreSelection methods in editor and mixerPaul Davis
2018-07-27new_grid: The Return of the snap_to_X functions.Ben Loftis
We no longer assume that Snap always uses the visible ruler lines. If you want to snap to the grid, and ignore the users zoom scale, use SnapPref::SnapToGrid_Unscaled This fixes 2 (known) oversights: "snap region(s) to grid" and "regions whose start are left of the canvas edge".
2018-06-08Allow snapping to the start of the video timeline. (should work, but needs ↵Ben Loftis
testing on a machine with harvid).
2018-05-17Playhead to Grid: handle case where PH is rolling, and we are prevented from ↵Ben Loftis
skipping backwards sensibly.
2018-05-08playhead_X_to_grid: Handle the case of GridTypeNoneBen Loftis
2018-05-08Arrow keys (playhead_x_to_grid()) should move the view along with it. This ↵Ben Loftis
is more consistent with jog-wheel operation, which has proven to work nicely.
2018-03-28fix undo/redo for duplicate-regions in ripple modePaul Davis
Also fix duplicate of multiple regions in the same track, and change "gap" variable name to "span" for greater clarity
2018-03-27duplicate (regions) should honor ripple edit modePaul Davis
2018-02-27Reinstate the ability to split regions while dragging playhead. I think ↵Ben Loftis
this was unintentionally lost.
2018-02-27Remove some redundant calls to snap_to(). get_preferred_edit_position() ↵Ben Loftis
already did it.
2018-02-26Should be able to Split in range mode, with a selected track.Ben Loftis
2018-02-26Fix bug: sequential pasting to the same time, but different tracks, would ↵Ben Loftis
trigger paste offset.
2018-02-24Fixes for region_boundary_cache:Ben Loftis
If no region-snaps are defined, bail out before generating cache. Avoid potential overflow at max_samplepos+1 Snap should continue to work beyond the End marker.
2018-02-24NO-OP: whitespaceRobin Gareus
- remove trailing whitespace - remove space after opening brackets and before closing brackets - add space around operators - do not use '//' for multi-line comments, do not use "//" on line-start to comment-out code breaking indenting (-Wmisleading-indent) - do add a single space after comment-start /*{SPACE}... or //{SPACE}... - reserve duplicate whitespace " " for alignment, remove other duplicate whitespace - use established "TODO" and "XXX" (highlighted keywords) - remove equal-sign series "====" (those indicate merge conflicts)
2018-02-23Tell the user why Insert/Remove Time failed, rather than fail silently.Ben Loftis
2018-02-11SoloSelection: gui part.Ben Loftis
2018-02-09new_grid: Rewrite of Snap and Grid. (squashed commit)Ben Loftis
Separate Snap from Grid. Lots of naming changes. Multiple simultaneous snap options allowed. Grid is one of the possible Snap options. Grid uses the same data as the rulers. Replace complicated tempo_lines with simple grid_lines. The Grid is zoom-scale-sensitive along with the rulers. If you are zoomed out, grid becomes coarser.
2017-12-12NO-OP: whitespaceRobin Gareus
2017-12-11zoom-to-selection should clear the selection, afterwards.Ben Loftis
2017-11-23Remove unreachable code.Robin Gareus
if (working_on_selection) { ... } else { if (working_on_selection) { .. never reached .. } } Found by PVS: https://www.viva64.com/en/b/0540/
2017-10-26remove unused variablePaul Davis
2017-09-24convert codebase to use Temporal for various time typesPaul Davis
2017-09-18globally change all use of "frame" to refer to audio into "sample".Paul Davis
Generated by tools/f2s. Some hand-editing will be required in a few places to fix up comments related to timecode and video in order to keep the legible
2017-09-18changes required to operate with the Evoral::Beats ticktime commitPaul Davis
2017-09-18no more per-track varispeedPaul Davis