summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2020-02-22Tweak ArdorIcon display-tool & re-order iconsRobin Gareus
* add option to render a border * group icons (assume 7x7 grid)
2020-02-21avoid double-locate call when locating-while-stoppedPaul Davis
Session::locate() used TransportFSM::stopped() to determine if realtime stop was required. But this would return false, since the motion state at that time is WaitingForLocate. So invert the test and use !TransportFSM::rolling
2020-02-21fix playback glitch : do not adjust file_sample[Type] after read, it is ↵Paul Davis
canonical We told the DR to read from pos+shift, and it increment file_sample[T] appropriately. We should not adjust it. The only thing that gets adjusted is the sample that will playback (as a result of PlaybackBuffer::increment_read_ptr()
2020-02-21centralize determination of "read-audio-data-in-reverse" and fix seek ↵Paul Davis
"shift" offset There is still a bug related to "shift" that causes a playback discontinuity
2020-02-21make "reversing" back into a DirectionState and prohibit speed changes while ↵Paul Davis
reversing
2020-02-20Update Control flags of Aux SendsRobin Gareus
This fixes old session-state of sessions saved after 6.0-pre0-3039-g93180ceea9 and before 6.0-pre0-3459-g587fc50059. It's mainly relevant for Mixbus6.0
2020-02-20Fix Inline-control visibility stateRobin Gareus
This fixes an issue when copy/pasting plugins or aux-sends from one track to another. After copying the processor, the state is copied, however the Controllable state did save the InlineControl flag, so this as lost. (amend 93180ceea)
2020-02-20remove unused membersPaul Davis
2020-02-20fix up apparent design thinkos in US2400 key binding handlerPaul Davis
2020-02-20fix up apparent design thinkos in Mackie key binding handlerPaul Davis
2020-02-20use MIXBUS approach to User button for Faderport (it's just a button, not a ↵Paul Davis
modifier
2020-02-20Faderport(1): fix pan_azimuth direction by setting Rotary flag.Ben Loftis
2020-02-20MCU: fix pan_azimuth direction by setting Rotary flag.Ben Loftis
2020-02-20controllable::{get_set}_interface() are convenience wrappers for funcs that ↵Ben Loftis
need the Rotary flag set
2020-02-20Reset MIDI-control when a given ctrl is not availableRobin Gareus
This fixes an issue with "/route/eq/freq/0 S1": When a newly select strip that does not have a EQ (e.g. mixbus or master), the control from the previously selected strip is used. -- Reported by tavasti on IRC.
2020-02-20Fix copy/edit in c509c948244Robin Gareus
2020-02-20avoid setting midnam-model-name in GUI properties when there are no device ↵Paul Davis
modes for that model
2020-02-20change transport API, session API, transportFSM API to move reverse ↵Paul Davis
management and motion state (partially) into TFSM
2020-02-20add commentPaul Davis
2020-02-20when seeking in disk reader, adjust start of read (if possible) to allow ↵Paul Davis
some reverse internal seek allowance
2020-02-20fix test to decide if we can skip disk buffer refill because we're close ↵Paul Davis
enough (read direction must match)
2020-02-20variable name change (ffa ... 2nd f was "frame" => fsa ... s is "sample")Paul Davis
2020-02-20improve commentsPaul Davis
2020-02-20correctly track is disk read (audio) should be forwards/backwards, and what ↵Paul Davis
was done last time we read from disk
2020-02-20change variable name to be more meaningful/indicativePaul Davis
2020-02-20remove debug outputPaul Davis
2020-02-20NOOP: fix brace/newline usePaul Davis
2020-02-19expose PlaybackBuffer::reservation and make the member constPaul Davis
2020-02-19remove unused methodPaul Davis
2020-02-19when inside Route::set_state() and calling set_name(), call the virtual ↵Paul Davis
method, rather than Route::set_name() Without this, nothing in Track::set_name() is called, which means that tracks created from templates do not get their name set appropriately
2020-02-19fix paren/newline formattingPaul Davis
2020-02-20Force Disk-Reader channel count to match Disk-Writer I/O.Robin Gareus
This handles some special cases where a plugin is added after the disk-writer but before the disk-reader. The plugin may add/remove ports (e.g. an instrument: MIDI to audio, or some stereo to mono processors). However we need to ensure that any data that is recorded will be played back. This is a new take replacing b2bc934e2.
2020-02-20Revert "fix behavior of DiskReader when moved after an instrument"Robin Gareus
This reverts commit b2bc934e218a8ed05b6f37edc5585191e60ca288. The commit does causes issues when a user manually removes channels: The disk-reader's ::can_support_io_configuration() at first ignores the user's request, forcing the output channel count to match the DR's current channel config. However, when configuring the DiskReader after that, channels is updated to match the new input-count. Even though the DR itself only plays back using the confgured I/O, all processors after it still use the old channel count. Only a later, second re-configuration step will apply the actual removal to plugins and port. PS. the original commit was mainly intended to fix a crash when adding an instrument plugin *between* disk-writer and disk-reader on a MIDI track.
2020-02-20NO-OP: remove old comment and debug codeRobin Gareus
2020-02-20Fix crash on buffer override of N/A data-typesRobin Gareus
DiskReader::refill_audio and DR::run() do check if a given playlist is available. This is required for upcoming changes to set DR channels to unconditionally match DiskWriter.
2020-02-20Fix declick at transport start for multi-channel tracksRobin Gareus
2020-02-20Update scripts to new request_locate() APIRobin Gareus
2020-02-19fix old write source names being used after a track is renamedPaul Davis
2020-02-19fix compiler warning about dynamic_cast<T*>(ptr_to_T)Paul Davis
This is in a Route method, so it is obvious that dynamic_cast<Route*>(this) will return true
2020-02-19remove "destination_sample" from API for Session::set_transport_speed()Paul Davis
This was a leftover from changes made for Tracks Live, related to the concept of an auto-return preference. We don't use this anywhere in Ardour or Mixbus, and the concept should eventually be removed entirely.
2020-02-19Fix libreadline detectionRobin Gareus
This fixes building and bundling the "luasession" commandline tool, regression was introduced in 2e9ac80e99 (waf py2/3)
2020-02-19Remove unused dummy control classRobin Gareus
PBD::IgnorableControllable() is no longer used. It also was problematic, because in every case where a Controllable is required, min/max range and usually also get/set value are significant.
2020-02-19Fix Latency GUI numeric entryRobin Gareus
2020-02-18Prompt user when deleting a VCA (amends 01c6f5)Ben Loftis
Editor::remove_tracks expected the VCA to be selected, but right-click does not force selection in a VCA strip.
2020-02-18Enumerate the polarity buttons from the polarity processor itself, not the ↵Ben Loftis
Input count.
2020-02-18Prompt user before removing a VCA in the mixer window.Ben Loftis
2020-02-18Fix loading send gain automationRobin Gareus
This cleans up various issues that have been accumulated over the past and fixes bugs introduced in d4e023e1 and e31f5d99. Previously GainControl as saved as part of the Amp, however the automation was saved via Send (is-a Automatable). In d4e023e1cb, the GainControl was changed a "BusSendLevel" parameter, but AutomationList was not updated. This prevented loading existing automation (control parameter was not found).
2020-02-18Add/remove source(s) in our MSVC project (gtk2_ardour)John Emmas
2020-02-18GUI Dialog to inform the user about missing filesRobin Gareus
So far this is only used for MIDI, missing audio files are already handled by asking a user to locate them. The same approach doesn't work for MIDI, since there cannot be externally referenced (embedded) .mid files (since MIDI is destructive).
2020-02-18Replace missing .mid files with silenceRobin Gareus
This fixes a crash: missing playlist due to missing .mid, and retains regions for missing MIDI files. As opposed to missing Audio, we cannot use a SilentFileSource, because MIDI files are destructive. This also adds an API to query missing files that have been replaced with silence to report them to the user.