summaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2017-04-19Use PBD::to_string() in LV2Plugin instead of string_compose for state_dirTim Mayberry
To prevent issues with numeric grouping with formatting used by string_compose template/stringstream when global C++ locale != "C"
2017-04-19Use std::string::operator+ instead of string_compose in VSTPluginTim Mayberry
2017-04-19Use std::string::operator+() instead of string_compose template in Route classTim Mayberry
Using string_compose in this instance doesn't seem necessary, is worse in terms of readability and is no doubt slower.
2017-04-19Remove PBD::to_string() function from pbd/convert.hTim Mayberry
All uses of this function have now been replaced by PBD::to_string() from pbd/string_convert.h Remove this function so that it isn't mistakenly used to perform numeric to string conversion when the result is being used for serialization as that only works if the global C++ locale is set with LC_NUMERIC=C, which is the case currently but may not be in the future.
2017-04-19Use PBD::to_string() from pbd/string_convert.h in VCATimeAxisViewTim Mayberry
2017-04-19Use PBD::to_string from pbd/string_convert.h in VCAMasterStrip classTim Mayberry
2017-04-19Use PBD::to_string from pbd/string_convert.h in SoundFileBox classTim Mayberry
Numeric formatting is equivalent.
2017-04-19Use PBD::to_string from pbd/string_convert.h in RouteTimeAxisTim Mayberry
Numeric formatting is equivalent as LC_NUMERIC=C in global C++ locale
2017-04-19Use PBD::to_string from pbd/string_convert.h in MixerStrip classTim Mayberry
The numeric formatting is equivalent. Even though this string is being used in the UI as a label I think this is another case where we don't want a localized numeric string, which would only be relevant with a track count >=1000.
2017-04-19Use PBD::to_string from pbd/string_convert.h in MeterStrip classTim Mayberry
The numeric formatting is equivalent. The string is being used in a label so it could be argued that we want localized numeric formatting in this case, but as it is only relevant if we have >=1000 meter strip keep it the same for now.
2017-04-19Use PBD::to_string from pbd/string_convert.h in ExportTimespanSelectorTim Mayberry
The C++ global locale is currently set to LC_NUMERIC=C by the first instance of LocaleGuard so this change means numeric formatting is equivalent. As the string is being used to construct a label, perhaps we do want to generate localized numeric formatting in this case. Anyway keep it the same for now.
2017-04-19Use PBD::to_string() from pbd/string_convert.h in ControlSlaveUITim Mayberry
The numeric formatting is equivalent.
2017-04-19Use PBD::to_string from pbd/string_convert.h in WaveView debug codeTim Mayberry
2017-04-19Use PBD::to_string from pbd/string_convert.h in ARDOUR::VCAManagerTim Mayberry
The numeric formatting is equivalent to iostreams when global C++ locale is set to "C" without the need for a LocaleGuard. I'm not sure this would have been an issue as the number of VCA's may never get high enough for digit grouping of the locale to affect numeric output, but now it is not a possibility.
2017-04-19Use PBD::string_to/to_string in ARDOUR::user_config_directory_name()Tim Mayberry
The numeric formatting is equivalent without requiring a LocaleGuard or the global C++ locale is "C".
2017-04-19Use PBD::to_string from pbd/string_convert.h in ARDOUR::ExportFilenameTim Mayberry
The numeric formatting is equivalent to using iostreams in the C locale without having to use a LocaleGuard or set global C++ locale.
2017-04-19Use XMLNode::get_property in ARDOUR::ElementImporterTim Mayberry
2017-04-19Use PBD::to_string/string_to in ARDOUR::ElementImporter classTim Mayberry
2017-04-19Use PBD::to_string API from pbd/string_convert.h in AudioFileTaggerTim Mayberry
Use pbd/string_convert.h API instead of std::ostream for numeric formatting to remain locale independent and not have to use a LocaleGuard. The formatting is equivalent.
2017-04-19Use PBD::to_string API from pbd/string_convert.h in AudioTrackImporterTim Mayberry
Use pbd/string_convert.h API instead of std::ostream for numeric formatting to remain locale independent and not have to use a LocaleGuard. The formatting is equivalent. The code in this file has been disabled in the GUI for some time...and I doubt it would now work correctly.
2017-04-19Use PBD::to_string() from pbd/string_convert.h in ardour ALSA utilsTim Mayberry
Use pbd/string_convert.h API instead of std::ostream for numeric formatting to remain locale independent and not have to use a LocaleGuard. The formatting is equivalent
2017-04-19Use PBD::to_string() from pbd/string_convert.h in JACK utilsTim Mayberry
Use pbd/string_convert.h API instead of std::ostream for numeric formatting to remain locale independent and not have to use a LocaleGuard.
2017-04-19Use PBD::string_to/to_string when de/serializing in AutomationList classTim Mayberry
This avoids requiring a LocaleGuard to get the correct numeric formatting and saves/restores the automation data to the precision required for roundtrip equality.
2017-04-19Remove unused header include in ARDOUR::Amp source fileTim Mayberry
2017-04-19Use PBD::string_to/to_string in IO::find_possible_bundleTim Mayberry
Possible issue with numeric formatting using std::streams in locales with grouping. Although I don't think it would be an issue in this case use locale independant alternative for numeric formatting anyway.
2017-04-19Use PBD::to_string instead of std::ostream when setting up video server urlTim Mayberry
To avoid issues with locales that use grouping/thousands separators.
2017-04-19Use PBD::to_string to convert period count in EngineControl classTim Mayberry
The functionality is the same so might as well use it.
2017-04-19Use PBD::to_string to convert bufsize to string in EngineControl classTim Mayberry
string_compose uses std::ostream/stringstream which will insert thousands separators in some locales. This was not a problem when LocaleGuard set the global C++ locale to "C"
2017-04-19Use PBD::string_to functions in VideoUtils::video_query_infoTim Mayberry
LocaleGuard is in use so float <=> string conversions must be expected in C locale format
2017-04-19Use snprintf instead of std::stringstream when converting color values to ↵Tim Mayberry
strings std::ostream/stringstream will use the current locale to determine the numeric formatting. If the locale uses grouping then thousands separators will be inserted in the output which produces an invalid color string in UIConfiguration::reset_gtk_theme() and when converting colors to strings in UIConfiguration::store_color_theme() This has not been a problem so far because it appears that LocaleGuard does not reset the LC_NUMERIC value for the global C++ locale. So if a LocaleGuard is created at any time before these functions are called(even if it goes out of scope) the numeric formatting used by std::streams will use the "C" locale formatting facets.
2017-04-19Use XMLNode::get/set_property API in Faderport surfaceTim Mayberry
2017-04-19Remove now unused PBD::string_is_affirmative functionTim Mayberry
The equivalent function is now PBD::string_to<bool>
2017-04-19Use PBD::string_to<bool> in MidiTimeAxisView classTim Mayberry
As the conversion was performed with PBD::to_string
2017-04-19Use PBD::string_to<bool> in RouteTimeAxisView classTim Mayberry
As they were converted from bool to string using PBD::to_string
2017-04-19Remove conditional checks that are always true in RouteTimeAxisView classTim Mayberry
2017-04-19Use PBD::string_to<bool>() in GenericMidiControlProtocol classTim Mayberry
Equivalent to PBD::string_is_affirmative()
2017-04-19Use PBD::string_to<bool> in legacy ARDOUR::Route methodsTim Mayberry
2017-04-19Use PBD::string_to<bool> in ARDOUR::Processor classTim Mayberry
2017-04-19Use PBD::string_to<bool> in AudioPlaylist classTim Mayberry
2017-04-19Use AxisView::get/set_gui_property API in RouteTimeAxisView classTim Mayberry
2017-04-19Use AxisView::get/set_gui_property API in MixerStrip classTim Mayberry
2017-04-19Use AxisView::get_gui_property API in AutomationTimeAxis classTim Mayberry
2017-04-19Use AxisView::get_gui_property in AudioRegionView classTim Mayberry
2017-04-19Use AxisView::get_gui_property API in TimeAxisView classTim Mayberry
2017-04-19Use AxisView::get_gui_property API in AxisView classTim Mayberry
2017-04-19Add AxisView::get_gui_property method, use PBD::string_to<T> for string ↵Tim Mayberry
conversion
2017-04-19Use PBD::to_string to convert non-string types in AxisView::set_gui_propertyTim Mayberry
2017-04-19Let AxisView::set_gui_property perform type conversion in ↵Tim Mayberry
TimeAxisView::set_height
2017-04-19Remove unused XMLNode::add_property methodsTim Mayberry
These are now unused and functionality is replaced by XMLNode::set_property set_property is a better name as a node can only have properties with unique names and the property will be set or reset(if it already exists). Changing the name also makes it easier to transition and test the new API.
2017-04-19Use XMLNode::set_property API in xml testsTim Mayberry