Age | Commit message (Collapse) | Author | |
---|---|---|---|
2017-04-19 | Use PBD::to_string from pbd/string_convert.h in MeterStrip class | Tim Mayberry | |
The numeric formatting is equivalent. The string is being used in a label so it could be argued that we want localized numeric formatting in this case, but as it is only relevant if we have >=1000 meter strip keep it the same for now. | |||
2017-04-19 | Use PBD::to_string from pbd/string_convert.h in ExportTimespanSelector | Tim Mayberry | |
The C++ global locale is currently set to LC_NUMERIC=C by the first instance of LocaleGuard so this change means numeric formatting is equivalent. As the string is being used to construct a label, perhaps we do want to generate localized numeric formatting in this case. Anyway keep it the same for now. | |||
2017-04-19 | Use PBD::to_string() from pbd/string_convert.h in ControlSlaveUI | Tim Mayberry | |
The numeric formatting is equivalent. | |||
2017-04-19 | Use PBD::to_string from pbd/string_convert.h in WaveView debug code | Tim Mayberry | |
2017-04-19 | Use PBD::to_string from pbd/string_convert.h in ARDOUR::VCAManager | Tim Mayberry | |
The numeric formatting is equivalent to iostreams when global C++ locale is set to "C" without the need for a LocaleGuard. I'm not sure this would have been an issue as the number of VCA's may never get high enough for digit grouping of the locale to affect numeric output, but now it is not a possibility. | |||
2017-04-19 | Use PBD::string_to/to_string in ARDOUR::user_config_directory_name() | Tim Mayberry | |
The numeric formatting is equivalent without requiring a LocaleGuard or the global C++ locale is "C". | |||
2017-04-19 | Use PBD::to_string from pbd/string_convert.h in ARDOUR::ExportFilename | Tim Mayberry | |
The numeric formatting is equivalent to using iostreams in the C locale without having to use a LocaleGuard or set global C++ locale. | |||
2017-04-19 | Use XMLNode::get_property in ARDOUR::ElementImporter | Tim Mayberry | |
2017-04-19 | Use PBD::to_string/string_to in ARDOUR::ElementImporter class | Tim Mayberry | |
2017-04-19 | Use PBD::to_string API from pbd/string_convert.h in AudioFileTagger | Tim Mayberry | |
Use pbd/string_convert.h API instead of std::ostream for numeric formatting to remain locale independent and not have to use a LocaleGuard. The formatting is equivalent. | |||
2017-04-19 | Use PBD::to_string API from pbd/string_convert.h in AudioTrackImporter | Tim Mayberry | |
Use pbd/string_convert.h API instead of std::ostream for numeric formatting to remain locale independent and not have to use a LocaleGuard. The formatting is equivalent. The code in this file has been disabled in the GUI for some time...and I doubt it would now work correctly. | |||
2017-04-19 | Use PBD::to_string() from pbd/string_convert.h in ardour ALSA utils | Tim Mayberry | |
Use pbd/string_convert.h API instead of std::ostream for numeric formatting to remain locale independent and not have to use a LocaleGuard. The formatting is equivalent | |||
2017-04-19 | Use PBD::to_string() from pbd/string_convert.h in JACK utils | Tim Mayberry | |
Use pbd/string_convert.h API instead of std::ostream for numeric formatting to remain locale independent and not have to use a LocaleGuard. | |||
2017-04-19 | Use PBD::string_to/to_string when de/serializing in AutomationList class | Tim Mayberry | |
This avoids requiring a LocaleGuard to get the correct numeric formatting and saves/restores the automation data to the precision required for roundtrip equality. | |||
2017-04-19 | Remove unused header include in ARDOUR::Amp source file | Tim Mayberry | |
2017-04-19 | Use PBD::string_to/to_string in IO::find_possible_bundle | Tim Mayberry | |
Possible issue with numeric formatting using std::streams in locales with grouping. Although I don't think it would be an issue in this case use locale independant alternative for numeric formatting anyway. | |||
2017-04-19 | Use PBD::to_string instead of std::ostream when setting up video server url | Tim Mayberry | |
To avoid issues with locales that use grouping/thousands separators. | |||
2017-04-19 | Use PBD::to_string to convert period count in EngineControl class | Tim Mayberry | |
The functionality is the same so might as well use it. | |||
2017-04-19 | Use PBD::to_string to convert bufsize to string in EngineControl class | Tim Mayberry | |
string_compose uses std::ostream/stringstream which will insert thousands separators in some locales. This was not a problem when LocaleGuard set the global C++ locale to "C" | |||
2017-04-19 | Use PBD::string_to functions in VideoUtils::video_query_info | Tim Mayberry | |
LocaleGuard is in use so float <=> string conversions must be expected in C locale format | |||
2017-04-19 | Use snprintf instead of std::stringstream when converting color values to ↵ | Tim Mayberry | |
strings std::ostream/stringstream will use the current locale to determine the numeric formatting. If the locale uses grouping then thousands separators will be inserted in the output which produces an invalid color string in UIConfiguration::reset_gtk_theme() and when converting colors to strings in UIConfiguration::store_color_theme() This has not been a problem so far because it appears that LocaleGuard does not reset the LC_NUMERIC value for the global C++ locale. So if a LocaleGuard is created at any time before these functions are called(even if it goes out of scope) the numeric formatting used by std::streams will use the "C" locale formatting facets. | |||
2017-04-19 | Use XMLNode::get/set_property API in Faderport surface | Tim Mayberry | |
2017-04-19 | Remove now unused PBD::string_is_affirmative function | Tim Mayberry | |
The equivalent function is now PBD::string_to<bool> | |||
2017-04-19 | Use PBD::string_to<bool> in MidiTimeAxisView class | Tim Mayberry | |
As the conversion was performed with PBD::to_string | |||
2017-04-19 | Use PBD::string_to<bool> in RouteTimeAxisView class | Tim Mayberry | |
As they were converted from bool to string using PBD::to_string | |||
2017-04-19 | Remove conditional checks that are always true in RouteTimeAxisView class | Tim Mayberry | |
2017-04-19 | Use PBD::string_to<bool>() in GenericMidiControlProtocol class | Tim Mayberry | |
Equivalent to PBD::string_is_affirmative() | |||
2017-04-19 | Use PBD::string_to<bool> in legacy ARDOUR::Route methods | Tim Mayberry | |
2017-04-19 | Use PBD::string_to<bool> in ARDOUR::Processor class | Tim Mayberry | |
2017-04-19 | Use PBD::string_to<bool> in AudioPlaylist class | Tim Mayberry | |
2017-04-19 | Use AxisView::get/set_gui_property API in RouteTimeAxisView class | Tim Mayberry | |
2017-04-19 | Use AxisView::get/set_gui_property API in MixerStrip class | Tim Mayberry | |
2017-04-19 | Use AxisView::get_gui_property API in AutomationTimeAxis class | Tim Mayberry | |
2017-04-19 | Use AxisView::get_gui_property in AudioRegionView class | Tim Mayberry | |
2017-04-19 | Use AxisView::get_gui_property API in TimeAxisView class | Tim Mayberry | |
2017-04-19 | Use AxisView::get_gui_property API in AxisView class | Tim Mayberry | |
2017-04-19 | Add AxisView::get_gui_property method, use PBD::string_to<T> for string ↵ | Tim Mayberry | |
conversion | |||
2017-04-19 | Use PBD::to_string to convert non-string types in AxisView::set_gui_property | Tim Mayberry | |
2017-04-19 | Let AxisView::set_gui_property perform type conversion in ↵ | Tim Mayberry | |
TimeAxisView::set_height | |||
2017-04-19 | Remove unused XMLNode::add_property methods | Tim Mayberry | |
These are now unused and functionality is replaced by XMLNode::set_property set_property is a better name as a node can only have properties with unique names and the property will be set or reset(if it already exists). Changing the name also makes it easier to transition and test the new API. | |||
2017-04-19 | Use XMLNode::set_property API in xml tests | Tim Mayberry | |
2017-04-19 | Use XMLNode::set_property API in copy-mixer Session utility | Tim Mayberry | |
2017-04-19 | Use XMLNode::get_property in AudioClock class | Tim Mayberry | |
2017-04-19 | Use XMLNode::get/set_property API in VideoTimeLine class | Tim Mayberry | |
2017-04-19 | Use XMLNode::set_property API in VideoMonitor class | Tim Mayberry | |
2017-04-19 | Use XMLNode::set_property API in UIConfiguration class | Tim Mayberry | |
2017-04-19 | Use XMLNode::get/set_property API in SelectionMemento class | Tim Mayberry | |
2017-04-19 | Use XMLNode::get/set_property API in Selection class | Tim Mayberry | |
There were many possible value truncations occuring and some precision loss with the double conversions. | |||
2017-04-19 | Use XMLNode::get/set_property API in ProcessorBox and ProcessorWindowProxy ↵ | Tim Mayberry | |
classes | |||
2017-04-19 | Use XMLNode::get/set_property API in ProcessorBox class | Tim Mayberry | |