diff options
Diffstat (limited to 'libs/gtkmm2ext')
| -rw-r--r-- | libs/gtkmm2ext/pixfader.cc | 19 |
1 files changed, 17 insertions, 2 deletions
diff --git a/libs/gtkmm2ext/pixfader.cc b/libs/gtkmm2ext/pixfader.cc index 41203afb69..c138d13371 100644 --- a/libs/gtkmm2ext/pixfader.cc +++ b/libs/gtkmm2ext/pixfader.cc @@ -138,7 +138,7 @@ PixFader::on_button_release_event (GdkEventButton* ev) { double fract, ev_pos; - ev_pos = (_orien == VERT) ? ev->y : 0; // Don't step if we are horizontal + ev_pos = (_orien == VERT) ? ev->y : ev->x; switch (ev->button) { case 1: @@ -190,6 +190,7 @@ bool PixFader::on_scroll_event (GdkEventScroll* ev) { double scale; + bool ret = false; if (ev->state & fine_scale_modifier) { if (ev->state & extra_fine_scale_modifier) { @@ -202,35 +203,49 @@ PixFader::on_scroll_event (GdkEventScroll* ev) } if (_orien == VERT) { + + /* should left/right scroll affect vertical faders ? */ + switch (ev->direction) { case GDK_SCROLL_UP: /* wheel up */ adjustment.set_value (adjustment.get_value() + (adjustment.get_page_increment() * scale)); + ret = true; break; case GDK_SCROLL_DOWN: /* wheel down */ adjustment.set_value (adjustment.get_value() - (adjustment.get_page_increment() * scale)); + ret = true; break; default: break; } } else { + + /* up/down scrolls should definitely affect horizontal faders + because they are so much easier to use + */ + switch (ev->direction) { case GDK_SCROLL_RIGHT: + case GDK_SCROLL_UP: /* wheel right */ adjustment.set_value (adjustment.get_value() + (adjustment.get_page_increment() * scale)); + ret = true; break; case GDK_SCROLL_LEFT: + case GDK_SCROLL_DOWN: /* wheel left */ adjustment.set_value (adjustment.get_value() - (adjustment.get_page_increment() * scale)); + ret = true; break; default: break; } } - return false; + return ret; } bool |