*** NEW CODING POLICY ***

All #include statements that include a header that is a part of a library
bundled with ardour MUST use quotes, not angle brackets.

Do this:

#include "ardour/types.h"

NOT this:

#include <ardour/types.h>

Rationale:

This is best practice in general, to ensure we include the local version
and not the system version.  That quotes mean "local" (in some sense)
and angle brackets mean "system" (in some sense) is a ubiquitous
convention and IIRC right in the C spec somewhere.

More pragmatically, this is required by (my) waf (stuff) for dependencies
to work correctly.  That is:

!!! FAILURE TO DO THIS CAN RESULT IN BROKEN BUILDS !!!

Failure to comply is punishable by death by torture. :)

P.S. It's not that dramatic in all cases, but this (in combination with some
GCC flags specific to the include type) is the best way I have found to be
absolutely 100% positive the local ones are being used (and we definitely
want to be absolutely 100% positive on that one).


git-svn-id: svn://localhost/ardour2/branches/3.0@4655 d708f5d6-7413-0410-9779-e7cbd77b26cf

15 files changed, 27 insertions, 27 deletions

diff --git a/libs/pbd/pbd/abstract_ui.cc b/libs/pbd/pbd/abstract_ui.cc
index 8e5b9ceb07..a4c92c0de9 100644
--- a/libs/pbd/pbd/abstract_ui.cc
+++ b/libs/pbd/pbd/abstract_ui.cc
@@ -1,8 +1,8 @@
 #include <unistd.h>
 
-#include <pbd/abstract_ui.h>
-#include <pbd/pthread_utils.h>
-#include <pbd/failed_constructor.h>
+#include "pbd/abstract_ui.h"
+#include "pbd/pthread_utils.h"
+#include "pbd/failed_constructor.h"
 
 #include "i18n.h"
 
diff --git a/libs/pbd/pbd/abstract_ui.h b/libs/pbd/pbd/abstract_ui.h
index 88c27aa0bc..adb9aabf0e 100644
--- a/libs/pbd/pbd/abstract_ui.h
+++ b/libs/pbd/pbd/abstract_ui.h
@@ -28,9 +28,9 @@
 
 #include <glibmm/thread.h>
 
-#include <pbd/receiver.h>
-#include <pbd/ringbufferNPT.h>
-#include <pbd/base_ui.h>
+#include "pbd/receiver.h"
+#include "pbd/ringbufferNPT.h"
+#include "pbd/base_ui.h"
 
 class Touchable;
 
diff --git a/libs/pbd/pbd/command.h b/libs/pbd/pbd/command.h
index 1521a60350..240118901c 100644
--- a/libs/pbd/pbd/command.h
+++ b/libs/pbd/pbd/command.h
@@ -21,7 +21,7 @@
 #ifndef __lib_pbd_command_h__
 #define __lib_pbd_command_h__
 
-#include <pbd/statefuldestructible.h>
+#include "pbd/statefuldestructible.h"
 #include <boost/utility.hpp>
 
 class Command : public PBD::StatefulDestructible, public boost::noncopyable
diff --git a/libs/pbd/pbd/controllable.h b/libs/pbd/pbd/controllable.h
index 6d37464419..0007e04fd3 100644
--- a/libs/pbd/pbd/controllable.h
+++ b/libs/pbd/pbd/controllable.h
@@ -26,7 +26,7 @@
 #include <sigc++/trackable.h>
 #include <sigc++/signal.h>
 
-#include <pbd/statefuldestructible.h>
+#include "pbd/statefuldestructible.h"
 
 class XMLNode;
 
diff --git a/libs/pbd/pbd/crossthread.h b/libs/pbd/pbd/crossthread.h
index b815cfd319..c63c863f38 100644
--- a/libs/pbd/pbd/crossthread.h
+++ b/libs/pbd/pbd/crossthread.h
@@ -20,7 +20,7 @@
 #ifndef __pbd__crossthread_h__
 #define __pbd__crossthread_h__
 
-#include <pbd/abstract_ui.h>
+#include "pbd/abstract_ui.h"
 #include <sigc++/sigc++.h>
 #include <pthread.h>
 
diff --git a/libs/pbd/pbd/file_utils.h b/libs/pbd/pbd/file_utils.h
index a9832ce720..ce5422db13 100644
--- a/libs/pbd/pbd/file_utils.h
+++ b/libs/pbd/pbd/file_utils.h
@@ -25,7 +25,7 @@
 
 #include <glibmm/pattern.h>
 
-#include <pbd/search_path.h>
+#include "pbd/search_path.h"
 
 namespace PBD {
 
diff --git a/libs/pbd/pbd/filesystem_paths.h b/libs/pbd/pbd/filesystem_paths.h
index 4e09c6ec4b..8b767a3dfc 100644
--- a/libs/pbd/pbd/filesystem_paths.h
+++ b/libs/pbd/pbd/filesystem_paths.h
@@ -21,7 +21,7 @@
 
 #include <vector>
 
-#include <pbd/filesystem.h>
+#include "pbd/filesystem.h"
 
 namespace PBD {
 
diff --git a/libs/pbd/pbd/functor_command.h b/libs/pbd/pbd/functor_command.h
index e6c07cfdbe..b651c6f775 100644
--- a/libs/pbd/pbd/functor_command.h
+++ b/libs/pbd/pbd/functor_command.h
@@ -25,10 +25,10 @@
 #include <string>
 #include <map>
 
-#include <pbd/xml++.h>
-#include <pbd/shiva.h>
-#include <pbd/command.h>
-#include <pbd/failed_constructor.h>
+#include "pbd/xml++.h"
+#include "pbd/shiva.h"
+#include "pbd/command.h"
+#include "pbd/failed_constructor.h"
 
 /** This command class is initialized 
  */
diff --git a/libs/pbd/pbd/memento_command.h b/libs/pbd/pbd/memento_command.h
index 1a6600b1b5..e89da70c20 100644
--- a/libs/pbd/pbd/memento_command.h
+++ b/libs/pbd/pbd/memento_command.h
@@ -23,10 +23,10 @@
 
 #include <iostream>
 
-#include <pbd/command.h>
-#include <pbd/stacktrace.h>
-#include <pbd/xml++.h>
-#include <pbd/shiva.h>
+#include "pbd/command.h"
+#include "pbd/stacktrace.h"
+#include "pbd/xml++.h"
+#include "pbd/shiva.h"
 
 #include <sigc++/slot.h>
 #include <typeinfo>
diff --git a/libs/pbd/pbd/pool.h b/libs/pbd/pbd/pool.h
index d604680ae2..66a87abf96 100644
--- a/libs/pbd/pbd/pool.h
+++ b/libs/pbd/pbd/pool.h
@@ -25,7 +25,7 @@
 
 #include <glibmm/thread.h>
 
-#include <pbd/ringbuffer.h>
+#include "pbd/ringbuffer.h"
 
 class Pool 
 {
diff --git a/libs/pbd/pbd/search_path.h b/libs/pbd/pbd/search_path.h
index 505583b3e0..6163aae607 100644
--- a/libs/pbd/pbd/search_path.h
+++ b/libs/pbd/pbd/search_path.h
@@ -23,7 +23,7 @@
 #include <string>
 #include <vector>
 
-#include <pbd/filesystem.h>
+#include "pbd/filesystem.h"
 
 namespace PBD {
 
diff --git a/libs/pbd/pbd/stateful.h b/libs/pbd/pbd/stateful.h
index 8ea647475a..0d75a8579a 100644
--- a/libs/pbd/pbd/stateful.h
+++ b/libs/pbd/pbd/stateful.h
@@ -21,7 +21,7 @@
 #define __pbd_stateful_h__
 
 #include <string>
-#include <pbd/id.h>
+#include "pbd/id.h"
 
 class XMLNode;
 
diff --git a/libs/pbd/pbd/statefuldestructible.h b/libs/pbd/pbd/statefuldestructible.h
index 83eff473d6..49a33ff438 100644
--- a/libs/pbd/pbd/statefuldestructible.h
+++ b/libs/pbd/pbd/statefuldestructible.h
@@ -20,8 +20,8 @@
 #ifndef __pbd_stateful_destructible_h__
 #define __pbd_stateful_destructible_h__
 
-#include <pbd/stateful.h>
-#include <pbd/destructible.h>
+#include "pbd/stateful.h"
+#include "pbd/destructible.h"
 
 namespace PBD {
 
diff --git a/libs/pbd/pbd/tokenizer.h b/libs/pbd/pbd/tokenizer.h
index 9206d1b6fb..39954194fb 100644
--- a/libs/pbd/pbd/tokenizer.h
+++ b/libs/pbd/pbd/tokenizer.h
@@ -23,7 +23,7 @@
 #include <iterator>
 #include <string>
 
-#include <pbd/whitespace.h>
+#include "pbd/whitespace.h"
 
 namespace PBD {
 
diff --git a/libs/pbd/pbd/undo.h b/libs/pbd/pbd/undo.h
index cf1f6f3470..0e48bea962 100644
--- a/libs/pbd/pbd/undo.h
+++ b/libs/pbd/pbd/undo.h
@@ -26,8 +26,8 @@
 #include <sigc++/slot.h>
 #include <sigc++/bind.h>
 #include <sys/time.h>
-#include <pbd/command.h>
-#include <pbd/shiva.h>
+#include "pbd/command.h"
+#include "pbd/shiva.h"
 
 typedef sigc::slot<void> UndoAction;