diff options
| author | Robin Gareus <robin@gareus.org> | 2013-08-01 00:35:24 +0200 |
|---|---|---|
| committer | Robin Gareus <robin@gareus.org> | 2013-08-01 00:35:24 +0200 |
| commit | 4dc74ae2ea13d2e5a8b481961d507df1ff98df97 (patch) | |
| tree | 78dec5b3fc587a50e111e554478eb07475831594 /libs/ardour/plugin_insert.cc | |
| parent | f81cbe06ea3439d0c58057ae40ea63f1b6bf484b (diff) | |
use zeroed scratch buffers for "silent" plugin runs
Plugins rewrite the buffer data in-place and some plugins
can produce output even when fed with silence.
Hence, during a PluginInsert::silence() run a plugin can
inject data into the "silent" buffers which causes side-effects.
Kudos to Chris 'oofus' Goddard for finding this issue.
Diffstat (limited to 'libs/ardour/plugin_insert.cc')
| -rw-r--r-- | libs/ardour/plugin_insert.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/libs/ardour/plugin_insert.cc b/libs/ardour/plugin_insert.cc index 998a03e3aa..d519dbd7a7 100644 --- a/libs/ardour/plugin_insert.cc +++ b/libs/ardour/plugin_insert.cc @@ -448,7 +448,7 @@ PluginInsert::silence (framecnt_t nframes) } for (Plugins::iterator i = _plugins.begin(); i != _plugins.end(); ++i) { - (*i)->connect_and_run (_session.get_silent_buffers ((*i)->get_info()->n_inputs), in_map, out_map, nframes, 0); + (*i)->connect_and_run (_session.get_scratch_buffers ((*i)->get_info()->n_inputs, true), in_map, out_map, nframes, 0); } } |