diff options
| author | Paul Davis <paul@linuxaudiosystems.com> | 2011-12-15 02:19:21 +0000 |
|---|---|---|
| committer | Paul Davis <paul@linuxaudiosystems.com> | 2011-12-15 02:19:21 +0000 |
| commit | 38707ea06b6b4c786c7679a2cba96811d4beef27 (patch) | |
| tree | 1641db55d85341e8f02fb7fcaa93d0b59a8d6639 /gtk2_ardour/processor_box.cc | |
| parent | 96585e532c879220057edd050806c823ed6e4c1d (diff) | |
do not delete GtkUIManager-generated menu from ProcessorBox when the PB is destroyed. read the comment for more details
git-svn-id: svn://localhost/ardour2/branches/3.0@11008 d708f5d6-7413-0410-9779-e7cbd77b26cf
Diffstat (limited to 'gtk2_ardour/processor_box.cc')
| -rw-r--r-- | gtk2_ardour/processor_box.cc | 10 |
1 files changed, 9 insertions, 1 deletions
diff --git a/gtk2_ardour/processor_box.cc b/gtk2_ardour/processor_box.cc index 7ad56cced3..3040061dc9 100644 --- a/gtk2_ardour/processor_box.cc +++ b/gtk2_ardour/processor_box.cc @@ -505,7 +505,15 @@ ProcessorBox::ProcessorBox (ARDOUR::Session* sess, boost::function<PluginSelecto ProcessorBox::~ProcessorBox () { - delete processor_menu; + /* it may appear as if we should delete processor_menu but that is a + * pointer to a widget owned by the UI Manager, and has potentially + * be returned to many other ProcessorBoxes. GTK doesn't really make + * clear the ownership of this widget, which is a menu and thus is + * never packed into any container other than an implict GtkWindow. + * + * For now, until or if we ever get clarification over the ownership + * story just let it continue to exist. At worst, its a small memory leak. + */ } void |