Prevent huge stack allocations for MIDNAM files

xmlParseMemory() uses a c-pointer char*.
Previously MIDNAM data on the heap were wrapped inside
a std::string only to be later accessed via c_str().

2 files changed, 3 insertions, 3 deletions

diff --git a/libs/pbd/pbd/xml++.h b/libs/pbd/pbd/xml++.h
index e4e28c4655..d17f77bd3c 100644
--- a/libs/pbd/pbd/xml++.h
+++ b/libs/pbd/pbd/xml++.h
@@ -91,7 +91,7 @@ public:
 	bool read(const std::string& fn) { set_filename(fn); return read_internal(false); }
 	bool read_and_validate() { return read_internal(true); }
 	bool read_and_validate(const std::string& fn) { set_filename(fn); return read_internal(true); }
-	bool read_buffer(const std::string&, bool to_tree_doc = false);
+	bool read_buffer(char const*, bool to_tree_doc = false);
 
 	bool write() const;
 	bool write(const std::string& fn) { set_filename(fn); return write(); }
diff --git a/libs/pbd/xml++.cc b/libs/pbd/xml++.cc
index e09af7602b..bb2dd3e7ca 100644
--- a/libs/pbd/xml++.cc
+++ b/libs/pbd/xml++.cc
@@ -124,7 +124,7 @@ XMLTree::read_internal(bool validate)
 }
 
 bool
-XMLTree::read_buffer(const string& buffer, bool to_tree_doc)
+XMLTree::read_buffer (char const* buffer, bool to_tree_doc)
 {
 	xmlDocPtr doc;
 
@@ -133,7 +133,7 @@ XMLTree::read_buffer(const string& buffer, bool to_tree_doc)
 	delete _root;
 	_root = 0;
 
-	doc = xmlParseMemory(const_cast<char*>(buffer.c_str()), buffer.length());
+	doc = xmlParseMemory (buffer, strlen(buffer));
 	if (!doc) {
 		return false;
 	}