Fix Searchpath::operator+ to return by value rather than reference and not modify *this

ladspa_search_path was the only function using this API and it is unaffected by
the change

1 files changed, 4 insertions, 7 deletions

diff --git a/libs/pbd/search_path.cc b/libs/pbd/search_path.cc
index 44438cc85c..1d931a546d 100644
--- a/libs/pbd/search_path.cc
+++ b/libs/pbd/search_path.cc
@@ -124,19 +124,16 @@ Searchpath::operator+= (const std::string& directory_path)
 	return *this;
 }
 
-Searchpath&
+const Searchpath
 Searchpath::operator+ (const std::string& directory_path)
 {
-	add_directory (directory_path);
-	return *this;
+	return Searchpath (*this) += directory_path;
 }
 
-Searchpath&
+const Searchpath
 Searchpath::operator+ (const Searchpath& spath)
 {
-	// concatenate paths into new Searchpath
-	insert(end(), spath.begin(), spath.end());
-	return *this;
+	return Searchpath (*this) += spath;
 }
 
 Searchpath&