diff options
| author | Paul Davis <paul@linuxaudiosystems.com> | 2019-10-26 19:51:47 -0600 |
|---|---|---|
| committer | Paul Davis <paul@linuxaudiosystems.com> | 2019-11-02 16:32:18 -0600 |
| commit | 7dfae40e3b271605c9ebbba25f8ff921f9c7ae0e (patch) | |
| tree | 9494951484660b1b72507d07170b6ab75eb95241 /libs/ardour/midi_playlist_source.cc | |
| parent | 17ba6d319fd0935f5842a66f6ec8bbc1e05026d3 (diff) | |
comment out actual action in MidiPlaylistSource::read()
See comment and remember that we do not MidiPlaylistSource at this time.
Diffstat (limited to 'libs/ardour/midi_playlist_source.cc')
| -rw-r--r-- | libs/ardour/midi_playlist_source.cc | 15 |
1 files changed, 13 insertions, 2 deletions
diff --git a/libs/ardour/midi_playlist_source.cc b/libs/ardour/midi_playlist_source.cc index 6797fbacab..7339918b07 100644 --- a/libs/ardour/midi_playlist_source.cc +++ b/libs/ardour/midi_playlist_source.cc @@ -139,7 +139,19 @@ MidiPlaylistSource::read_unlocked (const Lock& lock, return 0; } - return mp->read (dst, start, cnt, loop_range); + /* XXX paul says on Oct 26 2019: + + rgareus: so to clarify now that i have better perspective: the API i want to get rid of is MidiPlaylist::read() ; everything that used it (i.e. the DiskReader) should use MidiPlaylist::rendered()->read() + rgareus: but a "read" operation is also a "write" operation: you have to put the data somewhere + rgareus: the only other user of MidiPlaylist::read() was MidiPlaylistSource (unsurprisingly), which as I noted is not even (really) used + rgareus: ::rendered() returns a ptr-to-RT_MidiBuffer, which has a read method which expects to write into a MidiBuffer, using push_back() + rgareus: but MidiPlaylistSource::read() is given an EventSink<samplepos_t> as the destination, and this does not (currently) have ::push_back(), only ::write() (which is willing to deal with inserts rather than appends) + rgareus: so, this is the API "mess" I'm trying to clean up. simple solution: since we don't use MidiPlaylistSource just comment out the line and forget about it for now, then remove MidiPlaylist::read() and move on + + This represents that decision, for now. + */ + + return cnt; // mp->read (dst, start, cnt, loop_range); } samplecnt_t @@ -190,4 +202,3 @@ MidiPlaylistSource::empty () const { return !_playlist || _playlist->empty(); } - |