summaryrefslogtreecommitdiff
path: root/libs/ardour/ardour/plugin.h
diff options
context:
space:
mode:
authorRobin Gareus <robin@gareus.org>2017-02-28 20:08:03 +0100
committerRobin Gareus <robin@gareus.org>2017-02-28 20:20:18 +0100
commita80920c016127d7601bb89ba32c0beb7040c4cdf (patch)
tree3760557a1dd60cbe33007f40bd54a250b8dbf514 /libs/ardour/ardour/plugin.h
parentc7168b387bda1b5e8dd1314ae608af7789305c77 (diff)
Tweak/optimize VST callback:
The audioMasterAutomate callback from plugin to host does include the parameter-value. Previously there was a redundant call Plugin::parameter_changed_externally() -> get_parameter -> VSTPlugin::get_parameter() back into the plugin to query the value. calling back into the plugin from the callback, may explain oddities and/or crashes with some VSTs.
Diffstat (limited to 'libs/ardour/ardour/plugin.h')
-rw-r--r--libs/ardour/ardour/plugin.h2
1 files changed, 1 insertions, 1 deletions
diff --git a/libs/ardour/ardour/plugin.h b/libs/ardour/ardour/plugin.h
index e4efb2a441..ce9c2f4268 100644
--- a/libs/ardour/ardour/plugin.h
+++ b/libs/ardour/ardour/plugin.h
@@ -333,7 +333,7 @@ protected:
/* Called when a parameter of the plugin is changed outside of this
* host's control (typical via a plugin's own GUI/editor)
*/
- void parameter_changed_externally (uint32_t which, float val);
+ virtual void parameter_changed_externally (uint32_t which, float val);
/* should be overridden by plugin API specific derived types to
* actually implement changing the parameter. The derived type should