Overhaul InstrumentInfo

* Remove unused direct calls into plugin
* Assume empty model to mean plugin-provided MIDNAM (!)

The route owned Instrument-Info is the central access point used
by the GUI for MIDI name lookups.

At this point in time, custom settings are saved/restored by the
GUI (MidiTimeAxisView). InstrumentInfo provides a volatile store
for MIDNAM mode and model.

1 files changed, 0 insertions, 20 deletions

diff --git a/libs/ardour/ardour/plugin.h b/libs/ardour/ardour/plugin.h
index cdcc313578..7ffbc1fdf9 100644
--- a/libs/ardour/ardour/plugin.h
+++ b/libs/ardour/ardour/plugin.h
@@ -250,26 +250,6 @@ public:
 
 	std::vector<PresetRecord> get_presets ();
 
-	/** @return true if this plugin will respond to MIDI program
-	 * change messages by changing presets.
-	 *
-	 * This is hard to return a correct value for because most plugin APIs
-	 * do not specify plugin behaviour. However, if you want to force
-	 * the display of plugin built-in preset names rather than MIDI program
-	 * numbers, return true. If you want a generic description, return
-	 * false.
-	 */
-	virtual bool presets_are_MIDI_programs () const { return false; }
-
-	/** @return true if this plugin is General MIDI compliant, false
-	 * otherwise.
-	 *
-	 * It is important to note that it is is almost impossible for a host
-	 * (e.g. Ardour) to determine this for just about any plugin API
-	 * known as of June 2012
-	 */
-	virtual bool current_preset_uses_general_midi () const { return false; }
-
 	/** @return Last preset to be requested; the settings may have
 	 * been changed since; find out with parameter_changed_since_last_preset.
 	 */