diff options
| author | Robin Gareus <robin@gareus.org> | 2020-02-20 01:17:14 +0100 |
|---|---|---|
| committer | Robin Gareus <robin@gareus.org> | 2020-02-20 01:57:11 +0100 |
| commit | c8f114612446b612ebe9f53da65b33e4f6adef0f (patch) | |
| tree | a047dff2b20874badd345b28b8863fbf4a7019f6 /libs/ardour/ardour/disk_reader.h | |
| parent | 4337e2b0543c2e2183ca3c87caf924e247cd6213 (diff) | |
Revert "fix behavior of DiskReader when moved after an instrument"
This reverts commit b2bc934e218a8ed05b6f37edc5585191e60ca288.
The commit does causes issues when a user manually removes channels:
The disk-reader's ::can_support_io_configuration() at first ignores
the user's request, forcing the output channel count to match the
DR's current channel config.
However, when configuring the DiskReader after that, channels is updated
to match the new input-count.
Even though the DR itself only plays back using the confgured I/O,
all processors after it still use the old channel count.
Only a later, second re-configuration step will apply the actual removal
to plugins and port.
PS. the original commit was mainly intended to fix a crash when
adding an instrument plugin *between* disk-writer and disk-reader
on a MIDI track.
Diffstat (limited to 'libs/ardour/ardour/disk_reader.h')
| -rw-r--r-- | libs/ardour/ardour/disk_reader.h | 2 |
1 files changed, 0 insertions, 2 deletions
diff --git a/libs/ardour/ardour/disk_reader.h b/libs/ardour/ardour/disk_reader.h index 3116435606..725fa4b2ce 100644 --- a/libs/ardour/ardour/disk_reader.h +++ b/libs/ardour/ardour/disk_reader.h @@ -50,8 +50,6 @@ public: static samplecnt_t default_chunk_samples (); static void set_chunk_samples (samplecnt_t n) { _chunk_samples = n; } - bool can_support_io_configuration (const ChanCount& in, ChanCount& out); - void run (BufferSet& /*bufs*/, samplepos_t /*start_sample*/, samplepos_t /*end_sample*/, double speed, pframes_t /*nframes*/, bool /*result_required*/); void realtime_handle_transport_stopped (); void realtime_locate (bool); |