Create a new layer if required on record to a track in stacked mode. Fixes #3391.

git-svn-id: svn://localhost/ardour2/branches/3.0@8026 d708f5d6-7413-0410-9779-e7cbd77b26cf

7 files changed, 125 insertions, 57 deletions

diff --git a/gtk2_ardour/audio_streamview.cc b/gtk2_ardour/audio_streamview.cc
index ee94d9bde3..c66685d5d7 100644
--- a/gtk2_ardour/audio_streamview.cc
+++ b/gtk2_ardour/audio_streamview.cc
@@ -619,69 +619,73 @@ AudioStreamView::rec_peak_range_ready (nframes_t start, nframes_t cnt, boost::we
 	rec_data_ready_map[src] = true;
 
 	if (rec_data_ready_map.size() == _trackview.track()->n_channels().n_audio()) {
-		this->update_rec_regions ();
+		update_rec_regions (start, cnt);
 		rec_data_ready_map.clear();
 	}
 }
 
 void
-AudioStreamView::update_rec_regions ()
+AudioStreamView::update_rec_regions (framepos_t start, framecnt_t cnt)
 {
-	if (Config->get_show_waveforms_while_recording ()) {
-		uint32_t n = 0;
-
-		for (list<pair<boost::shared_ptr<Region>,RegionView*> >::iterator iter = rec_regions.begin();
-				iter != rec_regions.end(); n++) {
-
-			list<pair<boost::shared_ptr<Region>,RegionView*> >::iterator tmp = iter;
-			++tmp;
-
-			if (!canvas_item_visible (rec_rects[n].rectangle)) {
-				/* rect already hidden, this region is done */
-				iter = tmp;
-				continue;
-			}
+	if (!Config->get_show_waveforms_while_recording ()) {
+		return;
+	}
+	
+	uint32_t n = 0;
+	
+	for (list<pair<boost::shared_ptr<Region>,RegionView*> >::iterator iter = rec_regions.begin(); iter != rec_regions.end(); n++) {
+		
+		list<pair<boost::shared_ptr<Region>,RegionView*> >::iterator tmp = iter;
+		++tmp;
+		
+		if (!canvas_item_visible (rec_rects[n].rectangle)) {
+			/* rect already hidden, this region is done */
+			iter = tmp;
+			continue;
+		}
+		
+		boost::shared_ptr<AudioRegion> region = boost::dynamic_pointer_cast<AudioRegion>(iter->first);
+		
+		if (!region) {
+			iter = tmp;
+			continue;
+		}
+		
+		nframes_t origlen = region->length();
 
-			boost::shared_ptr<AudioRegion> region = boost::dynamic_pointer_cast<AudioRegion>(iter->first);
+		if (region == rec_regions.back().first && rec_active) {
 			
-			if (!region) {
-				iter = tmp;
-				continue;
-			}
-
-			nframes_t origlen = region->length();
-
-			if (region == rec_regions.back().first && rec_active) {
-
-				if (last_rec_data_frame > region->start()) {
-
-					nframes_t nlen = last_rec_data_frame - region->start();
-
-					if (nlen != region->length()) {
-
-						region->suspend_property_changes ();
-						region->set_position (_trackview.track()->get_capture_start_frame(n), this);
-						region->set_length (nlen, this);
-						region->resume_property_changes ();
-
-						if (origlen == 1) {
-							/* our special initial length */
-							add_region_view_internal (region, false, true);
-						}
+			if (last_rec_data_frame > region->start()) {
+				
+				nframes_t nlen = last_rec_data_frame - region->start();
+				
+				if (nlen != region->length()) {
 
-						/* also update rect */
-						ArdourCanvas::SimpleRect * rect = rec_rects[n].rectangle;
-						gdouble xend = _trackview.editor().frame_to_pixel (region->position() + region->length());
-						rect->property_x2() = xend;
+					region->suspend_property_changes ();
+					region->set_position (_trackview.track()->get_capture_start_frame(n), this);
+					region->set_length (nlen, this);
+					region->resume_property_changes ();
+					
+					if (origlen == 1) {
+						/* our special initial length */
+						add_region_view_internal (region, false, true);
+						setup_new_rec_layer_time (region);
 					}
+
+					check_record_layers (region, (region->position() - region->start() + start + cnt));
+					
+					/* also update rect */
+					ArdourCanvas::SimpleRect * rect = rec_rects[n].rectangle;
+					gdouble xend = _trackview.editor().frame_to_pixel (region->position() + region->length());
+					rect->property_x2() = xend;
 				}
 
 			} else {
-
+				
 				nframes_t nlen = _trackview.track()->get_captured_frames(n);
-
+				
 				if (nlen != region->length()) {
-
+					
 					if (region->source_length(0) >= region->start() + nlen) {
 
 						region->suspend_property_changes ();
diff --git a/gtk2_ardour/audio_streamview.h b/gtk2_ardour/audio_streamview.h
index 4f2ef2c7ed..f7b11dcf97 100644
--- a/gtk2_ardour/audio_streamview.h
+++ b/gtk2_ardour/audio_streamview.h
@@ -79,7 +79,7 @@ class AudioStreamView : public StreamView
   private:
 	void setup_rec_box ();
 	void rec_peak_range_ready (nframes_t start, nframes_t cnt, boost::weak_ptr<ARDOUR::Source> src);
-	void update_rec_regions ();
+	void update_rec_regions (ARDOUR::framepos_t, ARDOUR::framecnt_t);
 
 	RegionView* add_region_view_internal (boost::shared_ptr<ARDOUR::Region>, bool wait_for_waves, bool recording = false);
 	void remove_region_view (boost::weak_ptr<ARDOUR::Region> );
diff --git a/gtk2_ardour/midi_region_view.cc b/gtk2_ardour/midi_region_view.cc
index fcc8b6d0b3..6424b8b389 100644
--- a/gtk2_ardour/midi_region_view.cc
+++ b/gtk2_ardour/midi_region_view.cc
@@ -3152,6 +3152,8 @@ MidiRegionView::data_recorded (boost::shared_ptr<MidiBuffer> buf, boost::weak_pt
 	MidiTimeAxisView* mtv = dynamic_cast<MidiTimeAxisView*> (&trackview);
 	BeatsFramesConverter converter (trackview.session()->tempo_map(), mtv->midi_track()->get_capture_start_frame (0));
 
+	framepos_t back = max_framepos;
+	
 	for (MidiBuffer::iterator i = buf->begin(); i != buf->end(); ++i) {
 		Evoral::MIDIEvent<MidiBuffer::TimeType> const ev (*i, false);
 		assert (ev.buffer ());
@@ -3176,5 +3178,9 @@ MidiRegionView::data_recorded (boost::shared_ptr<MidiBuffer> buf, boost::weak_pt
 		} else if (ev.type() == MIDI_CMD_NOTE_OFF) {
 			resolve_note (ev.note (), time_beats);
 		}
+
+		back = ev.time ();
 	}
+
+	midi_stream_view()->check_record_layers (region(), back);
 }
diff --git a/gtk2_ardour/midi_streamview.cc b/gtk2_ardour/midi_streamview.cc
index ef625f0a1c..e47d83ae83 100644
--- a/gtk2_ardour/midi_streamview.cc
+++ b/gtk2_ardour/midi_streamview.cc
@@ -201,7 +201,7 @@ MidiStreamView::display_region(MidiRegionView* region_view, bool load_model)
 			source->model()->highest_note());
 
 	// Display region contents
-	region_view->set_height(height);
+	region_view->set_height (child_height());
 	region_view->display_model(source->model());
 }
 
@@ -294,7 +294,7 @@ void
 MidiStreamView::update_contents_height ()
 {
 	StreamView::update_contents_height();
-	_note_lines->property_y2() = height;
+	_note_lines->property_y2() = child_height ();
 
         apply_note_range (lowest_note(), highest_note(), true);
 }
@@ -312,7 +312,7 @@ MidiStreamView::draw_note_lines()
 
 	_note_lines->clear();
 	
-	if(height < 140){
+	if (child_height() < 140){
 		return;
 	}
 
@@ -364,13 +364,13 @@ MidiStreamView::apply_note_range(uint8_t lowest, uint8_t highest, bool to_region
 	_highest_note = highest;
 	_lowest_note = lowest;
 	
-	int range = _highest_note - _lowest_note;  
-	int pixels_per_note = floor (height/range);
+	int const range = _highest_note - _lowest_note;  
+	int const pixels_per_note = floor (child_height () / range);
 	
 	/* do not grow note height beyond 10 pixels */
 	if (pixels_per_note > 10) {
 		
-		int available_note_range = floor ((height)/10);
+		int const available_note_range = floor (child_height() / 10);
 		int additional_notes = available_note_range - range;
 		
 		/* distribute additional notes to higher and lower ranges, clamp at 0 and 127 */
@@ -469,6 +469,8 @@ MidiStreamView::setup_rec_box ()
 				// rec regions are destroyed in setup_rec_box
 
 				/* we add the region later */
+
+				setup_new_rec_layer_time (region);
 			}
 
 			/* start a new rec box */
@@ -611,3 +613,4 @@ MidiStreamView::update_rec_box ()
 	MidiRegionView* mrv = dynamic_cast<MidiRegionView*> (rec_regions.back().second);
 	mrv->extend_active_notes ();
 }
+
diff --git a/gtk2_ardour/midi_streamview.h b/gtk2_ardour/midi_streamview.h
index b29f030e61..0774fd61bd 100644
--- a/gtk2_ardour/midi_streamview.h
+++ b/gtk2_ardour/midi_streamview.h
@@ -77,7 +77,7 @@ class MidiStreamView : public StreamView
 	void redisplay_track ();
 
 	inline double contents_height() const
-	{ return (_trackview.current_height() - TimeAxisViewItem::NAME_HIGHLIGHT_SIZE - 2); }
+	{ return (child_height() - TimeAxisViewItem::NAME_HIGHLIGHT_SIZE - 2); }
 
 	inline double note_to_y(uint8_t note) const
 		{ return contents_height()
diff --git a/gtk2_ardour/streamview.cc b/gtk2_ardour/streamview.cc
index 5201cf295c..9f56f8c692 100644
--- a/gtk2_ardour/streamview.cc
+++ b/gtk2_ardour/streamview.cc
@@ -578,7 +578,16 @@ StreamView::update_contents_height ()
 	}
 
 	for (vector<RecBoxInfo>::iterator i = rec_rects.begin(); i != rec_rects.end(); ++i) {
-		i->rectangle->property_y2() = height;
+		switch (_layer_display) {
+		case Overlaid:
+			i->rectangle->property_y2() = height;
+			break;
+		case Stacked:
+			/* In stacked displays, the recregion is always at the top */
+			i->rectangle->property_y1() = 0;
+			i->rectangle->property_y2() = h;
+			break;
+		}
 	}
 }
 
@@ -598,3 +607,41 @@ StreamView::update_coverage_frames ()
 		(*i)->update_coverage_frames (_layer_display);
 	}
 }
+
+void
+StreamView::check_record_layers (boost::shared_ptr<Region> region, framepos_t to)
+{
+	if (_new_rec_layer_time < to) {
+		/* The region being recorded has overlapped the start of a top-layered region, so
+		   `fake' a new visual layer for the recording.  This is only a visual thing for now,
+		   as the proper layering will get sorted out when the recorded region is added to
+		   its playlist.
+		*/
+
+		/* Stop this happening again */
+		_new_rec_layer_time = max_framepos;
+		
+		/* Make space in the view for the new layer */
+		++_layers;
+		
+		/* Set the temporary region to the correct layer so that it gets drawn correctly */
+		region->set_layer (_layers - 1);
+		
+		/* and reset the view */
+		update_contents_height ();
+	}
+}
+
+void
+StreamView::setup_new_rec_layer_time (boost::shared_ptr<Region> region)
+{
+	/* If we are in Stacked mode, we may need to (visually) create a new layer to put the
+	   recorded region in.  To work out where this needs to happen, find the start of the next
+	   top-layered region after the start of the region we are recording and make a note of it.
+	*/
+	if (_layer_display == Stacked) {
+		_new_rec_layer_time = _trackview.track()->playlist()->find_next_top_layer_position (region->start());
+	} else {
+		_new_rec_layer_time = max_framepos;
+	}
+}
diff --git a/gtk2_ardour/streamview.h b/gtk2_ardour/streamview.h
index c29c206470..366bc8d4bf 100644
--- a/gtk2_ardour/streamview.h
+++ b/gtk2_ardour/streamview.h
@@ -113,6 +113,8 @@ public:
 		return 0;
 	}
 
+	void check_record_layers (boost::shared_ptr<ARDOUR::Region>, ARDOUR::framepos_t);
+	
 	sigc::signal<void,RegionView*> RegionViewAdded;
 
 protected:
@@ -171,6 +173,12 @@ protected:
 	PBD::ScopedConnectionList rec_data_ready_connections;
 	nframes_t                 last_rec_data_frame;
 
+	/* When recording, the session time at which a new layer must be created for the region
+	   being recorded, or max_framepos if not applicable.
+	*/
+	framepos_t _new_rec_layer_time;
+	void setup_new_rec_layer_time (boost::shared_ptr<ARDOUR::Region>);
+	
 private:
 	void update_coverage_frames ();
 };