diff options
| author | Robin Gareus <robin@gareus.org> | 2017-03-24 14:36:17 +0100 |
|---|---|---|
| committer | Robin Gareus <robin@gareus.org> | 2017-03-24 14:48:46 +0100 |
| commit | 962e7a214aa8841f88e5fbf6bb12499dfddeb269 (patch) | |
| tree | e6bd8a77440a43d4669ddcbfe761873a0e6c7f60 /gtk2_ardour/route_ui.cc | |
| parent | 55b8b44889d1d08fc6b64283670fd0953642ba64 (diff) | |
Revert "consistent use of context-menu popups"
This reverts commit b3722f7063699fafd0421d504e05a7300c70e0ec.
In some cases ardour shows context-menu on right-mouse-button
release. In this case selecting a menu-entry should happen
with the left-mouse button (or any button?!)
Using ev->button is only correct if the menu is temporary and only
visible while the button is held, button release then activates the
menu-item.
This needs further work, in some cases allowing any button (0) to work
makes sense and overall consistency needs to be improved.
Different places use different strategies for context-menus which
don't always match the button used in the event-handler.
This is a hotfix (to make TAV context menus work again with left-click)
Diffstat (limited to 'gtk2_ardour/route_ui.cc')
| -rw-r--r-- | gtk2_ardour/route_ui.cc | 10 |
1 files changed, 5 insertions, 5 deletions
diff --git a/gtk2_ardour/route_ui.cc b/gtk2_ardour/route_ui.cc index fee5838202..c8c48f257e 100644 --- a/gtk2_ardour/route_ui.cc +++ b/gtk2_ardour/route_ui.cc @@ -426,7 +426,7 @@ RouteUI::mute_press (GdkEventButton* ev) build_mute_menu(); } - mute_menu->popup(ev->button, ev->time); + mute_menu->popup(0,ev->time); return true; @@ -604,7 +604,7 @@ RouteUI::solo_press(GdkEventButton* ev) build_solo_menu (); } - solo_menu->popup (ev->button, ev->time); + solo_menu->popup (1, ev->time); } } else { @@ -1009,7 +1009,7 @@ RouteUI::rec_enable_release (GdkEventButton* ev) if (Keyboard::is_context_menu_event (ev)) { build_record_menu (); if (record_menu) { - record_menu->popup (ev->button, ev->time); + record_menu->popup (1, ev->time); } return false; } @@ -1128,7 +1128,7 @@ RouteUI::show_sends_press(GdkEventButton* ev) build_sends_menu (); } - sends_menu->popup (ev->button, ev->time); + sends_menu->popup (0, ev->time); } else { @@ -2139,7 +2139,7 @@ RouteUI::invert_press (GdkEventButton* ev) --_i_am_the_modifier; } - _invert_menu->popup (ev->button, ev->time); + _invert_menu->popup (0, ev->time); return true; } |