diff options
| author | Robin Gareus <robin@gareus.org> | 2017-11-23 11:29:07 +0100 |
|---|---|---|
| committer | Robin Gareus <robin@gareus.org> | 2017-11-23 11:29:07 +0100 |
| commit | a07bd2d5853aa7d383e325f0f5c1d88218e303c7 (patch) | |
| tree | 542062d0a4bade8c6be861f9497247cad956eb13 /gtk2_ardour/processor_selection.cc | |
| parent | c59136813393d782260265bd2c8dc923fc04e238 (diff) | |
Make static analysis happy..
If the copy c'tor of ProcessorSelection was actually used,
assigning the XMLProcessorSelection
processors = other.processors;
would lead to duplicate free() of the XMLNode*
XMLProcessorSelection would need a dedicated copy c'tor that
duplicates allocates a new XMLNode.
see also #10 at https://www.viva64.com/en/b/0540/
Anyway, the copy c'tor and assignment is never used. This commit makes
this explicit.
Diffstat (limited to 'gtk2_ardour/processor_selection.cc')
| -rw-r--r-- | gtk2_ardour/processor_selection.cc | 10 |
1 files changed, 0 insertions, 10 deletions
diff --git a/gtk2_ardour/processor_selection.cc b/gtk2_ardour/processor_selection.cc index a9833096d2..47a9fe22ec 100644 --- a/gtk2_ardour/processor_selection.cc +++ b/gtk2_ardour/processor_selection.cc @@ -18,16 +18,6 @@ #include "processor_selection.h" -ProcessorSelection& -ProcessorSelection::operator= (ProcessorSelection const & other) -{ - if (this != &other) { - processors = other.processors; - } - - return *this; -} - void ProcessorSelection::clear_processors () { |