summaryrefslogtreecommitdiff
path: root/gtk2_ardour/automation_controller.cc
diff options
context:
space:
mode:
authorRobin Gareus <robin@gareus.org>2017-03-24 14:36:17 +0100
committerRobin Gareus <robin@gareus.org>2017-03-24 14:48:46 +0100
commit962e7a214aa8841f88e5fbf6bb12499dfddeb269 (patch)
treee6bd8a77440a43d4669ddcbfe761873a0e6c7f60 /gtk2_ardour/automation_controller.cc
parent55b8b44889d1d08fc6b64283670fd0953642ba64 (diff)
Revert "consistent use of context-menu popups"
This reverts commit b3722f7063699fafd0421d504e05a7300c70e0ec. In some cases ardour shows context-menu on right-mouse-button release. In this case selecting a menu-entry should happen with the left-mouse button (or any button?!) Using ev->button is only correct if the menu is temporary and only visible while the button is held, button release then activates the menu-item. This needs further work, in some cases allowing any button (0) to work makes sense and overall consistency needs to be improved. Different places use different strategies for context-menus which don't always match the button used in the event-handler. This is a hotfix (to make TAV context menus work again with left-click)
Diffstat (limited to 'gtk2_ardour/automation_controller.cc')
-rw-r--r--gtk2_ardour/automation_controller.cc4
1 files changed, 2 insertions, 2 deletions
diff --git a/gtk2_ardour/automation_controller.cc b/gtk2_ardour/automation_controller.cc
index 0005589100..21e6b429cb 100644
--- a/gtk2_ardour/automation_controller.cc
+++ b/gtk2_ardour/automation_controller.cc
@@ -296,7 +296,7 @@ AutomationController::on_button_release(GdkEventButton* ev)
MenuList& items = menu->items();
items.push_back(MenuElem(_("Select Note..."),
sigc::mem_fun(*this, &AutomationController::run_note_select_dialog)));
- menu->popup(ev->button, ev->time);
+ menu->popup(1, ev->time);
return true;
} else if (desc.unit == ARDOUR::ParameterDescriptor::HZ) {
Gtk::Menu* menu = manage(new Menu());
@@ -320,7 +320,7 @@ AutomationController::on_button_release(GdkEventButton* ev)
(double)beats)));
}
}
- menu->popup(ev->button, ev->time);
+ menu->popup(1, ev->time);
return true;
}