diff options
| author | Robin Gareus <robin@gareus.org> | 2020-03-25 16:36:54 +0100 |
|---|---|---|
| committer | Robin Gareus <robin@gareus.org> | 2020-03-25 16:36:54 +0100 |
| commit | 89904468b317c3198af376de3048abbe4b3526e2 (patch) | |
| tree | 61d7044839da4bfadc9c57801a8a28762f80d7ad | |
| parent | 807915b40ca026dac8d0915f0e67f0133a7238d7 (diff) | |
Fix generic UI crash when plugin has ctrl outputs -- #7937
build_control_ui() special cases `AutomationControl mcontrol = NULL`
to create read-only output display. So Iterating over
Evoral::Control that are not AutomationControl must not crash.
This fixes a bug introduced in a44fecb740d3.
"Edit with generic controls" caused crashes for plugins with ctrl outs.
| -rw-r--r-- | gtk2_ardour/generic_pluginui.cc | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/gtk2_ardour/generic_pluginui.cc b/gtk2_ardour/generic_pluginui.cc index a885f8bfb8..5ca68db0a1 100644 --- a/gtk2_ardour/generic_pluginui.cc +++ b/gtk2_ardour/generic_pluginui.cc @@ -359,7 +359,7 @@ GenericPluginUI::build () = boost::dynamic_pointer_cast<ARDOUR::AutomationControl>( insert->control(param)); - if (c->flags () & Controllable::HiddenControl) { + if (c && c->flags () & Controllable::HiddenControl) { continue; } |