From 89904468b317c3198af376de3048abbe4b3526e2 Mon Sep 17 00:00:00 2001 From: Robin Gareus Date: Wed, 25 Mar 2020 16:36:54 +0100 Subject: Fix generic UI crash when plugin has ctrl outputs -- #7937 build_control_ui() special cases `AutomationControl mcontrol = NULL` to create read-only output display. So Iterating over Evoral::Control that are not AutomationControl must not crash. This fixes a bug introduced in a44fecb740d3. "Edit with generic controls" caused crashes for plugins with ctrl outs. --- gtk2_ardour/generic_pluginui.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gtk2_ardour/generic_pluginui.cc b/gtk2_ardour/generic_pluginui.cc index a885f8bfb8..5ca68db0a1 100644 --- a/gtk2_ardour/generic_pluginui.cc +++ b/gtk2_ardour/generic_pluginui.cc @@ -359,7 +359,7 @@ GenericPluginUI::build () = boost::dynamic_pointer_cast( insert->control(param)); - if (c->flags () & Controllable::HiddenControl) { + if (c && c->flags () & Controllable::HiddenControl) { continue; } -- cgit v1.2.3