From df60eca33cf4dda50e4508e4e85826ca69d4c19a Mon Sep 17 00:00:00 2001 From: Robin Gareus Date: Wed, 21 Aug 2019 03:05:17 +0200 Subject: Initialize uninitialized variable This fixes a potentially undefined branch if the USB device list is empty. dev is NULL, the loop is never entered, 'r' isn't set. if (!dev && !r) is undefined. --- libs/surfaces/contourdesign/contourdesign.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'libs') diff --git a/libs/surfaces/contourdesign/contourdesign.cc b/libs/surfaces/contourdesign/contourdesign.cc index db191be501..9e5f00231d 100644 --- a/libs/surfaces/contourdesign/contourdesign.cc +++ b/libs/surfaces/contourdesign/contourdesign.cc @@ -260,7 +260,7 @@ get_usb_device (uint16_t vendor_id, uint16_t product_id, libusb_device** device) struct libusb_device **devs; struct libusb_device *dev; size_t i = 0; - int r; + int r = LIBUSB_ERROR_NO_DEVICE; *device = 0; -- cgit v1.2.3