From 962e7a214aa8841f88e5fbf6bb12499dfddeb269 Mon Sep 17 00:00:00 2001 From: Robin Gareus Date: Fri, 24 Mar 2017 14:36:17 +0100 Subject: Revert "consistent use of context-menu popups" This reverts commit b3722f7063699fafd0421d504e05a7300c70e0ec. In some cases ardour shows context-menu on right-mouse-button release. In this case selecting a menu-entry should happen with the left-mouse button (or any button?!) Using ev->button is only correct if the menu is temporary and only visible while the button is held, button release then activates the menu-item. This needs further work, in some cases allowing any button (0) to work makes sense and overall consistency needs to be improved. Different places use different strategies for context-menus which don't always match the button used in the event-handler. This is a hotfix (to make TAV context menus work again with left-click) --- gtk2_ardour/ardour_ui_ed.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'gtk2_ardour/ardour_ui_ed.cc') diff --git a/gtk2_ardour/ardour_ui_ed.cc b/gtk2_ardour/ardour_ui_ed.cc index 905e2c5d07..18a8036217 100644 --- a/gtk2_ardour/ardour_ui_ed.cc +++ b/gtk2_ardour/ardour_ui_ed.cc @@ -901,7 +901,7 @@ ARDOUR_UI::tabbable_visibility_button_press (GdkEventButton* ev, string const& t string menu_name = string ("/ui/") + tabbable_name + X_("TabbableButtonMenu"); Gtk::Menu* menu = dynamic_cast (ActionManager::get_widget (menu_name.c_str())); if (menu) { - menu->popup (ev->button, ev->time); + menu->popup (3, ev->time); } return true; } -- cgit v1.2.3