From e68d441aa0aa550554b3a6ae7c3eeb33c0cc993f Mon Sep 17 00:00:00 2001 From: Robin Gareus Date: Wed, 17 Jul 2019 16:36:01 +0200 Subject: Fix patch-change bank update loop Without an object, the Unwinder has no scope and the "ignore" variable is never set. In this case: When the patch-bank was changed externally this lead to a duplicate recursive call to "refill_banks". --- gtk2_ardour/patch_change_widget.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/gtk2_ardour/patch_change_widget.cc b/gtk2_ardour/patch_change_widget.cc index f9c88d8068..de20c30bc5 100644 --- a/gtk2_ardour/patch_change_widget.cc +++ b/gtk2_ardour/patch_change_widget.cc @@ -229,7 +229,7 @@ PatchChangeWidget::refill_banks () const int b = bank (_channel); { - PBD::Unwinder (_ignore_spin_btn_signals, true); + PBD::Unwinder uw (_ignore_spin_btn_signals, true); _bank_msb_spin.set_value (b >> 7); _bank_lsb_spin.set_value (b & 127); } -- cgit v1.2.3