From b4242702086e46f56a3862900878d94afb0b434f Mon Sep 17 00:00:00 2001 From: Tim Mayberry Date: Sun, 21 Aug 2016 21:52:04 +1000 Subject: Fix string to float conversion when typing gain values in Gain Meter Remove the LocaleGuard so that the value of LC_NUMERIC is that of the users locale and sscanf will parse the string correctly. For instance, with a locale like nl_NL or fr_FR where the decimal point is different than the "C" locale, only the number up to the decimal point will be parsed by sscanf and input values will be rounded down. --- gtk2_ardour/gain_meter.cc | 12 +++--------- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/gtk2_ardour/gain_meter.cc b/gtk2_ardour/gain_meter.cc index 85122b93ee..55bdf4ce2f 100644 --- a/gtk2_ardour/gain_meter.cc +++ b/gtk2_ardour/gain_meter.cc @@ -477,15 +477,9 @@ GainMeterBase::gain_activated () { float f; - { - // Switch to user's preferred locale so that - // if they use different LC_NUMERIC conventions, - // we will honor them. - - PBD::LocaleGuard lg; - if (sscanf (gain_display.get_text().c_str(), "%f", &f) != 1) { - return; - } + // Use the user's preferred locale/LC_NUMERIC setting + if (sscanf (gain_display.get_text().c_str(), "%f", &f) != 1) { + return; } /* clamp to displayable values */ -- cgit v1.2.3