diff options
| author | Joan Lledó <joanlluislledo@gmail.com> | 2019-03-31 19:55:38 +0200 |
|---|---|---|
| committer | Samuel Thibault <samuel.thibault@ens-lyon.org> | 2019-03-31 20:01:00 +0200 |
| commit | 79c0f932c5465971b1de55672901b5920bab3c6b (patch) | |
| tree | ace49875ccd57a8b3e85eb923661b5cf6345b824 | |
| parent | 8619aea268c1bda2a536a65d8fbc24c4bcb9d239 (diff) | |
lwip: Fix wrong error checks
* lwip/lwip-util.c: init_ifs():
* Check for the value of ifc instead of in->dev_name
* lwip/port/netif/ifcommon.c:
* if_init(), if_terminate(): Check for null on ifc instead of netif
Message-Id: <20190331175541.7095-2-jlledom@member.fsf.org>
| -rw-r--r-- | lwip/lwip-util.c | 4 | ||||
| -rw-r--r-- | lwip/port/netif/ifcommon.c | 4 |
2 files changed, 4 insertions, 4 deletions
diff --git a/lwip/lwip-util.c b/lwip/lwip-util.c index 57a94d52..69991b4c 100644 --- a/lwip/lwip-util.c +++ b/lwip/lwip-util.c @@ -181,7 +181,7 @@ init_ifs (void *arg) /* * Create a new interface and configre IPv4. * - * Fifth parameter (in->name) is a hook. + * Fifth parameter (ifc) is a hook. */ err = netifapi_netif_add (netif, &in->address, &in->netmask, &in->gateway, &ifc, if_init, @@ -189,7 +189,7 @@ init_ifs (void *arg) if (err) { /* The interface failed to init */ - if (netif->state != in->dev_name) + if (netif->state != &ifc) /* It failed after setting the control block, must free it */ mem_free (netif->state); free (netif); diff --git a/lwip/port/netif/ifcommon.c b/lwip/port/netif/ifcommon.c index 11ede76d..c6179683 100644 --- a/lwip/port/netif/ifcommon.c +++ b/lwip/port/netif/ifcommon.c @@ -75,7 +75,7 @@ if_init (struct netif * netif) { struct ifcommon *ifc = netif_get_state (netif); - if (netif == NULL) + if (ifc == NULL) /* The user provided no interface */ return -1; @@ -89,7 +89,7 @@ if_terminate (struct netif * netif) error_t err; struct ifcommon *ifc = netif_get_state (netif); - if (netif == NULL) + if (ifc == NULL) /* The user provided no interface */ return -1; |