From cb48bb0e1ccdd8a8324e53e716b2058c2ef3c297 Mon Sep 17 00:00:00 2001
From: Robin Gareus <robin@gareus.org>
Date: Mon, 19 Jun 2017 12:40:51 +0200
Subject: remove min/max unbound -- LADSPA special case.

This explicit case should never have existed in the first place.

Plugins can always implicitly exceed the range and are expected to
cope with out-of-range values (e.g. meters when fed with a peaking signal
may return an out-of-bounds value)
---
 libs/ardour/ardour/parameter_descriptor.h | 2 --
 libs/ardour/audio_unit.cc                 | 2 --
 libs/ardour/ladspa_plugin.cc              | 5 -----
 libs/ardour/lv2_plugin.cc                 | 3 ---
 libs/ardour/parameter_descriptor.cc       | 4 ----
 libs/ardour/vst_plugin.cc                 | 2 --
 6 files changed, 18 deletions(-)

(limited to 'libs/ardour')

diff --git a/libs/ardour/ardour/parameter_descriptor.h b/libs/ardour/ardour/parameter_descriptor.h
index 60950bb14b..2348b05903 100644
--- a/libs/ardour/ardour/parameter_descriptor.h
+++ b/libs/ardour/ardour/parameter_descriptor.h
@@ -70,8 +70,6 @@ struct LIBARDOUR_API ParameterDescriptor : public Evoral::ParameterDescriptor
 	float                          largestep;
 	bool                           integer_step;
 	bool                           sr_dependent;
-	bool                           min_unbound;
-	bool                           max_unbound;
 	bool                           enumeration;
 };
 
diff --git a/libs/ardour/audio_unit.cc b/libs/ardour/audio_unit.cc
index 5d6204a227..da18b969f5 100644
--- a/libs/ardour/audio_unit.cc
+++ b/libs/ardour/audio_unit.cc
@@ -806,8 +806,6 @@ AUPlugin::discover_parameters ()
 				break;
 			}
 
-			d.min_unbound = 0; // lower is bound
-			d.max_unbound = 0; // upper is bound
 			d.update_steps();
 
 			descriptors.push_back (d);
diff --git a/libs/ardour/ladspa_plugin.cc b/libs/ardour/ladspa_plugin.cc
index f2bfe530e0..744293804f 100644
--- a/libs/ardour/ladspa_plugin.cc
+++ b/libs/ardour/ladspa_plugin.cc
@@ -469,20 +469,17 @@ LadspaPlugin::get_parameter_descriptor (uint32_t which, ParameterDescriptor& des
 
 
 	if (LADSPA_IS_HINT_BOUNDED_BELOW(prh.HintDescriptor)) {
-		desc.min_unbound = false;
 		if (LADSPA_IS_HINT_SAMPLE_RATE(prh.HintDescriptor)) {
 			desc.lower = prh.LowerBound * _session.frame_rate();
 		} else {
 			desc.lower = prh.LowerBound;
 		}
 	} else {
-		desc.min_unbound = true;
 		desc.lower = 0;
 	}
 
 
 	if (LADSPA_IS_HINT_BOUNDED_ABOVE(prh.HintDescriptor)) {
-		desc.max_unbound = false;
 		if (LADSPA_IS_HINT_SAMPLE_RATE(prh.HintDescriptor)) {
 			desc.upper = prh.UpperBound * _session.frame_rate();
 		} else {
@@ -490,10 +487,8 @@ LadspaPlugin::get_parameter_descriptor (uint32_t which, ParameterDescriptor& des
 		}
 	} else {
 		if (LADSPA_IS_HINT_TOGGLED (prh.HintDescriptor)) {
-			desc.max_unbound = false;
 			desc.upper = 1;
 		} else {
-			desc.max_unbound = true;
 			desc.upper = 4; /* completely arbitrary */
 		}
 	}
diff --git a/libs/ardour/lv2_plugin.cc b/libs/ardour/lv2_plugin.cc
index 6630f06af3..1c761166e0 100644
--- a/libs/ardour/lv2_plugin.cc
+++ b/libs/ardour/lv2_plugin.cc
@@ -2122,9 +2122,6 @@ LV2Plugin::get_parameter_descriptor(uint32_t which, ParameterDescriptor& desc) c
 		desc.upper *= _session.frame_rate ();
 	}
 
-	desc.min_unbound  = false; // TODO: LV2 extension required
-	desc.max_unbound  = false; // TODO: LV2 extension required
-
 	desc.enumeration = lilv_port_has_property(_impl->plugin, port, _world.lv2_enumeration);
 	desc.scale_points = get_scale_points(which);
 
diff --git a/libs/ardour/parameter_descriptor.cc b/libs/ardour/parameter_descriptor.cc
index 7acbb94772..29d13af540 100644
--- a/libs/ardour/parameter_descriptor.cc
+++ b/libs/ardour/parameter_descriptor.cc
@@ -44,8 +44,6 @@ ParameterDescriptor::ParameterDescriptor(const Evoral::Parameter& parameter)
 	, integer_step(parameter.type() >= MidiCCAutomation &&
 	               parameter.type() <= MidiChannelPressureAutomation)
 	, sr_dependent(false)
-	, min_unbound(0)
-	, max_unbound(0)
 	, enumeration(false)
 {
 	ScalePoints sp;
@@ -142,8 +140,6 @@ ParameterDescriptor::ParameterDescriptor()
 	, largestep(0)
 	, integer_step(false)
 	, sr_dependent(false)
-	, min_unbound(0)
-	, max_unbound(0)
 	, enumeration(false)
 {}
 
diff --git a/libs/ardour/vst_plugin.cc b/libs/ardour/vst_plugin.cc
index bf7637109d..23c2751ae3 100644
--- a/libs/ardour/vst_plugin.cc
+++ b/libs/ardour/vst_plugin.cc
@@ -328,8 +328,6 @@ VSTPlugin::get_parameter_descriptor (uint32_t which, ParameterDescriptor& desc)
 	VstParameterProperties prop;
 
 	memset (&prop, 0, sizeof (VstParameterProperties));
-	desc.min_unbound = false;
-	desc.max_unbound = false;
 	prop.flags = 0;
 
 	if (_plugin->dispatcher (_plugin, effGetParameterProperties, which, 0, &prop, 0)) {
-- 
cgit v1.2.3