From 484e0d0fb2548396f3e29b93f2ac9ddfae5aaeed Mon Sep 17 00:00:00 2001 From: Robin Gareus Date: Mon, 11 Mar 2019 02:10:50 +0100 Subject: Remove generic parameter-printer This has been superseded by value_as_string() along with meta-data from parameter-descriptor, which is supported by all standards, except VST. --- libs/ardour/ardour/audio_unit.h | 1 - libs/ardour/ardour/ladspa_plugin.h | 1 - libs/ardour/ardour/luaproc.h | 1 - libs/ardour/ardour/lv2_plugin.h | 4 ---- libs/ardour/ardour/plugin.h | 2 +- libs/ardour/ardour/vst_plugin.h | 2 +- libs/ardour/audio_unit.cc | 13 ------------- libs/ardour/ladspa_plugin.cc | 12 ------------ libs/ardour/luaproc.cc | 12 ------------ libs/ardour/lv2_plugin.cc | 12 ------------ libs/ardour/vst_plugin.cc | 7 ++++--- 11 files changed, 6 insertions(+), 61 deletions(-) (limited to 'libs/ardour') diff --git a/libs/ardour/ardour/audio_unit.h b/libs/ardour/ardour/audio_unit.h index 79f75c5ec0..562f7cc300 100644 --- a/libs/ardour/ardour/audio_unit.h +++ b/libs/ardour/ardour/audio_unit.h @@ -90,7 +90,6 @@ class LIBARDOUR_API AUPlugin : public ARDOUR::Plugin std::string describe_parameter (Evoral::Parameter); IOPortDescription describe_io_port (DataType dt, bool input, uint32_t id) const; std::string state_node_name () const { return "audiounit"; } - void print_parameter (uint32_t, char*, uint32_t len) const; bool parameter_is_audio (uint32_t) const; bool parameter_is_control (uint32_t) const; diff --git a/libs/ardour/ardour/ladspa_plugin.h b/libs/ardour/ardour/ladspa_plugin.h index 1557ef1ec3..de57586b0d 100644 --- a/libs/ardour/ardour/ladspa_plugin.h +++ b/libs/ardour/ardour/ladspa_plugin.h @@ -88,7 +88,6 @@ class LIBARDOUR_API LadspaPlugin : public ARDOUR::Plugin std::string describe_parameter (Evoral::Parameter); std::string state_node_name() const { return "ladspa"; } - void print_parameter (uint32_t, char*, uint32_t len) const; bool parameter_is_audio(uint32_t) const; bool parameter_is_control(uint32_t) const; diff --git a/libs/ardour/ardour/luaproc.h b/libs/ardour/ardour/luaproc.h index d311ebfcf6..d354bd8e51 100644 --- a/libs/ardour/ardour/luaproc.h +++ b/libs/ardour/ardour/luaproc.h @@ -92,7 +92,6 @@ public: pframes_t nframes, samplecnt_t offset); std::string describe_parameter (Evoral::Parameter); - void print_parameter (uint32_t, char*, uint32_t len) const; boost::shared_ptr get_scale_points(uint32_t port_index) const; bool parameter_is_audio (uint32_t) const { return false; } diff --git a/libs/ardour/ardour/lv2_plugin.h b/libs/ardour/ardour/lv2_plugin.h index e9f6bf0d09..9ec937edd0 100644 --- a/libs/ardour/ardour/lv2_plugin.h +++ b/libs/ardour/ardour/lv2_plugin.h @@ -118,10 +118,6 @@ class LIBARDOUR_API LV2Plugin : public ARDOUR::Plugin, public ARDOUR::Workee std::string describe_parameter (Evoral::Parameter); std::string state_node_name () const { return "lv2"; } - void print_parameter (uint32_t param, - char* buf, - uint32_t len) const; - bool parameter_is_audio (uint32_t) const; bool parameter_is_control (uint32_t) const; bool parameter_is_event (uint32_t) const; diff --git a/libs/ardour/ardour/plugin.h b/libs/ardour/ardour/plugin.h index 60a6db3ab2..4365958cfe 100644 --- a/libs/ardour/ardour/plugin.h +++ b/libs/ardour/ardour/plugin.h @@ -121,7 +121,7 @@ class LIBARDOUR_API Plugin : public PBD::StatefulDestructible, public HasLatency virtual std::set automatable() const = 0; virtual std::string describe_parameter (Evoral::Parameter) = 0; virtual std::string state_node_name() const = 0; - virtual void print_parameter (uint32_t, char*, uint32_t len) const = 0; + virtual bool print_parameter (uint32_t, char*, uint32_t len) const { return false; } virtual bool parameter_is_audio(uint32_t) const = 0; virtual bool parameter_is_control(uint32_t) const = 0; diff --git a/libs/ardour/ardour/vst_plugin.h b/libs/ardour/ardour/vst_plugin.h index 3c75c03490..47609a91f0 100644 --- a/libs/ardour/ardour/vst_plugin.h +++ b/libs/ardour/ardour/vst_plugin.h @@ -85,7 +85,7 @@ public: const char * maker () const; int32_t version () const; uint32_t parameter_count () const; - void print_parameter (uint32_t, char*, uint32_t len) const; + bool print_parameter (uint32_t, char*, uint32_t len) const; bool has_editor () const; diff --git a/libs/ardour/audio_unit.cc b/libs/ardour/audio_unit.cc index 9d79928bac..3244cb56a1 100644 --- a/libs/ardour/audio_unit.cc +++ b/libs/ardour/audio_unit.cc @@ -2035,19 +2035,6 @@ AUPlugin::describe_parameter (Evoral::Parameter param) } } -void -AUPlugin::print_parameter (uint32_t param, char* buf, uint32_t len) const -{ - // NameValue stuff here - if (buf && len) { - if (param < parameter_count()) { - snprintf (buf, len, "%.3f", get_parameter (param)); - } else { - strcat (buf, "0"); - } - } -} - bool AUPlugin::parameter_is_audio (uint32_t) const { diff --git a/libs/ardour/ladspa_plugin.cc b/libs/ardour/ladspa_plugin.cc index 3782200415..30b0bad11d 100644 --- a/libs/ardour/ladspa_plugin.cc +++ b/libs/ardour/ladspa_plugin.cc @@ -615,18 +615,6 @@ LadspaPlugin::parameter_is_input (uint32_t param) const return LADSPA_IS_PORT_INPUT(port_descriptor (param)); } -void -LadspaPlugin::print_parameter (uint32_t param, char *buf, uint32_t len) const -{ - if (buf && len) { - if (param < parameter_count()) { - snprintf (buf, len, "%.3f", get_parameter (param)); - } else { - strcat (buf, "0"); - } - } -} - boost::shared_ptr LadspaPlugin::get_scale_points(uint32_t port_index) const { diff --git a/libs/ardour/luaproc.cc b/libs/ardour/luaproc.cc index 58167e7f06..8cb5f66c1c 100644 --- a/libs/ardour/luaproc.cc +++ b/libs/ardour/luaproc.cc @@ -1003,18 +1003,6 @@ LuaProc::describe_parameter (Evoral::Parameter param) return "??"; } -void -LuaProc::print_parameter (uint32_t param, char* buf, uint32_t len) const -{ - if (buf && len) { - if (param < parameter_count ()) { - snprintf (buf, len, "%.3f", get_parameter (param)); - } else { - strcat (buf, "0"); - } - } -} - boost::shared_ptr LuaProc::parse_scale_points (luabridge::LuaRef* lr) { diff --git a/libs/ardour/lv2_plugin.cc b/libs/ardour/lv2_plugin.cc index 9f270f33b2..c4a1e0c24f 100644 --- a/libs/ardour/lv2_plugin.cc +++ b/libs/ardour/lv2_plugin.cc @@ -3066,18 +3066,6 @@ LV2Plugin::designated_bypass_port () return UINT32_MAX; } -void -LV2Plugin::print_parameter(uint32_t param, char* buf, uint32_t len) const -{ - if (buf && len) { - if (param < parameter_count()) { - snprintf(buf, len, "%.3f", get_parameter(param)); - } else { - strcat(buf, "0"); - } - } -} - boost::shared_ptr LV2Plugin::get_scale_points(uint32_t port_index) const { diff --git a/libs/ardour/vst_plugin.cc b/libs/ardour/vst_plugin.cc index d7cf0f32ad..7c68c07f92 100644 --- a/libs/ardour/vst_plugin.cc +++ b/libs/ardour/vst_plugin.cc @@ -806,7 +806,7 @@ VSTPlugin::has_editor () const return _plugin->flags & effFlagsHasEditor; } -void +bool VSTPlugin::print_parameter (uint32_t param, char *buf, uint32_t /*len*/) const { char *first_nonws; @@ -814,7 +814,7 @@ VSTPlugin::print_parameter (uint32_t param, char *buf, uint32_t /*len*/) const _plugin->dispatcher (_plugin, 7 /* effGetParamDisplay */, param, 0, buf, 0); if (buf[0] == '\0') { - return; + return false; } first_nonws = buf; @@ -823,10 +823,11 @@ VSTPlugin::print_parameter (uint32_t param, char *buf, uint32_t /*len*/) const } if (*first_nonws == '\0') { - return; + return false; } memmove (buf, first_nonws, strlen (buf) - (first_nonws - buf) + 1); + return true; } void -- cgit v1.2.3