From e0aaed6d65f160c328cb8b56d7c6552ee15d65e2 Mon Sep 17 00:00:00 2001 From: David Robillard Date: Wed, 25 Feb 2009 18:26:51 +0000 Subject: *** NEW CODING POLICY *** All #include statements that include a header that is a part of a library bundled with ardour MUST use quotes, not angle brackets. Do this: #include "ardour/types.h" NOT this: #include Rationale: This is best practice in general, to ensure we include the local version and not the system version. That quotes mean "local" (in some sense) and angle brackets mean "system" (in some sense) is a ubiquitous convention and IIRC right in the C spec somewhere. More pragmatically, this is required by (my) waf (stuff) for dependencies to work correctly. That is: !!! FAILURE TO DO THIS CAN RESULT IN BROKEN BUILDS !!! Failure to comply is punishable by death by torture. :) P.S. It's not that dramatic in all cases, but this (in combination with some GCC flags specific to the include type) is the best way I have found to be absolutely 100% positive the local ones are being used (and we definitely want to be absolutely 100% positive on that one). git-svn-id: svn://localhost/ardour2/branches/3.0@4655 d708f5d6-7413-0410-9779-e7cbd77b26cf --- libs/ardour/st_pitch.cc | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'libs/ardour/st_pitch.cc') diff --git a/libs/ardour/st_pitch.cc b/libs/ardour/st_pitch.cc index 3999c1a746..6138249e61 100644 --- a/libs/ardour/st_pitch.cc +++ b/libs/ardour/st_pitch.cc @@ -20,13 +20,13 @@ #include #include -#include +#include "pbd/error.h" -#include -#include -#include -#include -#include +#include "ardour/types.h" +#include "ardour/pitch.h" +#include "ardour/audiofilesource.h" +#include "ardour/session.h" +#include "ardour/audioregion.h" #include "i18n.h" -- cgit v1.2.3