From f806f059b3c229004cfbac50234062333fc38229 Mon Sep 17 00:00:00 2001 From: Paul Davis Date: Tue, 20 Oct 2015 10:12:21 -0400 Subject: rename Plugin::ParameterChanged to ParameterChangedExternally to reflect its intent, and clean up the libardour side of result. The signal exists to notify listeners that something outside of the host's control (e.g. a plugin's own GUI for AU or VST) has modified a plugin parameter. Previous code had strange feedback loops and ambiguous semantics. --- libs/ardour/plugin.cc | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) (limited to 'libs/ardour/plugin.cc') diff --git a/libs/ardour/plugin.cc b/libs/ardour/plugin.cc index f14c56798b..d68502713c 100644 --- a/libs/ardour/plugin.cc +++ b/libs/ardour/plugin.cc @@ -356,19 +356,21 @@ Plugin::clear_preset () PresetLoaded (); /* EMIT SIGNAL */ } -/** @param val `plugin' value */ void -Plugin::set_parameter (uint32_t which, float) +Plugin::set_parameter (uint32_t /* which */, float /* value */) { _parameter_changed_since_last_preset = true; _session.set_dirty (); - ParameterChanged (which, get_parameter (which)); /* EMIT SIGNAL */ + PresetDirty (); /* EMIT SIGNAL */ } void -Plugin::set_parameter_automated (uint32_t which, float val) +Plugin::parameter_changed_externally (uint32_t which, float /* value */) { - Plugin::set_parameter (which, val); + _parameter_changed_since_last_preset = true; + _session.set_dirty (); + ParameterChangedExternally (which, get_parameter (which)); /* EMIT SIGNAL */ + PresetDirty (); /* EMIT SIGNAL */ } int -- cgit v1.2.3