From 41b2de41d69c2ecc381867e502e4760267275425 Mon Sep 17 00:00:00 2001 From: Paul Davis Date: Mon, 7 Dec 2015 12:02:42 -0500 Subject: change API for accessing session MIDI ports so that (1) boost::shared_ptr<> is used all the time (2) we avoid using multiple functions to return different subclass versions of some ports --- libs/ardour/midi_ui.cc | 24 ++++++++++-------------- 1 file changed, 10 insertions(+), 14 deletions(-) (limited to 'libs/ardour/midi_ui.cc') diff --git a/libs/ardour/midi_ui.cc b/libs/ardour/midi_ui.cc index 59c718ad2b..eb6a372d86 100644 --- a/libs/ardour/midi_ui.cc +++ b/libs/ardour/midi_ui.cc @@ -71,9 +71,9 @@ MidiControlUI::do_request (MidiUIRequest* req) } bool -MidiControlUI::midi_input_handler (IOCondition ioc, AsyncMIDIPort* port) +MidiControlUI::midi_input_handler (IOCondition ioc, boost::shared_ptr port) { - DEBUG_TRACE (DEBUG::MidiIO, string_compose ("something happend on %1\n", ((ARDOUR::Port*)port)->name())); + DEBUG_TRACE (DEBUG::MidiIO, string_compose ("something happend on %1\n", boost::shared_ptr (port)->name())); if (ioc & ~IO_IN) { return false; @@ -81,12 +81,8 @@ MidiControlUI::midi_input_handler (IOCondition ioc, AsyncMIDIPort* port) if (ioc & IO_IN) { - AsyncMIDIPort* asp = dynamic_cast (port); - if (asp) { - asp->clear (); - } - - DEBUG_TRACE (DEBUG::MidiIO, string_compose ("data available on %1\n", ((ARDOUR::Port*)port)->name())); + port->clear (); + DEBUG_TRACE (DEBUG::MidiIO, string_compose ("data available on %1\n", boost::shared_ptr(port)->name())); framepos_t now = _session.engine().sample_time(); port->parse (now); } @@ -102,19 +98,19 @@ MidiControlUI::clear_ports () void MidiControlUI::reset_ports () { - vector ports; - AsyncMIDIPort* p; + vector > ports; + boost::shared_ptr p; - if ((p = dynamic_cast (_session.midi_input_port()))) { + if ((p = boost::dynamic_pointer_cast (_session.midi_input_port()))) { ports.push_back (p); } - if ((p = dynamic_cast (_session.mmc_input_port()))) { + if ((p = boost::dynamic_pointer_cast (_session.mmc_input_port()))) { ports.push_back (p); } - if ((p = dynamic_cast (_session.scene_input_port()))) { + if ((p = boost::dynamic_pointer_cast (_session.scene_input_port()))) { ports.push_back (p); } @@ -122,7 +118,7 @@ MidiControlUI::reset_ports () return; } - for (vector::const_iterator pi = ports.begin(); pi != ports.end(); ++pi) { + for (vector >::const_iterator pi = ports.begin(); pi != ports.end(); ++pi) { (*pi)->xthread().set_receive_handler (sigc::bind (sigc::mem_fun (this, &MidiControlUI::midi_input_handler), *pi)); (*pi)->xthread().attach (_main_loop->get_context()); } -- cgit v1.2.3