From c937a67f6ee7e9f280a097683528201489ae6930 Mon Sep 17 00:00:00 2001 From: Paul Davis Date: Mon, 30 May 2011 11:57:12 +0000 Subject: do not offer combine operation for MIDI (see comment in libs/ardour/midi_playlist_source.cc for an explanation) git-svn-id: svn://localhost/ardour2/branches/3.0@9630 d708f5d6-7413-0410-9779-e7cbd77b26cf --- libs/ardour/midi_playlist_source.cc | 21 +++++++++++++++------ 1 file changed, 15 insertions(+), 6 deletions(-) (limited to 'libs/ardour/midi_playlist_source.cc') diff --git a/libs/ardour/midi_playlist_source.cc b/libs/ardour/midi_playlist_source.cc index 713aadf5b1..bdf642281a 100644 --- a/libs/ardour/midi_playlist_source.cc +++ b/libs/ardour/midi_playlist_source.cc @@ -46,11 +46,22 @@ using namespace std; using namespace ARDOUR; using namespace PBD; +/******************************************************************************* +As of May 2011, it appears too complex to support compound regions for MIDI +because of the need to be able to edit the data represented by the region. It +seems that it would be a better idea to render the consituent regions into a +new MIDI file and create a new region based on that, an operation we have been +calling "consolidate" + +This code has been in place as a stub in case anyone gets any brilliant ideas +on other ways to approach this issue. +********************************************************************************/ + MidiPlaylistSource::MidiPlaylistSource (Session& s, const ID& orig, const std::string& name, boost::shared_ptr p, uint32_t chn, frameoffset_t begin, framecnt_t len, Source::Flag flags) - : Source (s, DataType::AUDIO, name) + : Source (s, DataType::MIDI, name) , MidiSource (s, name, flags) - , PlaylistSource (s, orig, name, p, DataType::AUDIO, begin, len, flags) + , PlaylistSource (s, orig, name, p, DataType::MIDI, begin, len, flags) { } @@ -157,15 +168,13 @@ MidiPlaylistSource::append_event_unlocked_frames(const Evoral::Event void MidiPlaylistSource::load_model (bool, bool) { - fatal << string_compose (_("programming error: %1"), "MidiPlaylistSource::load_model() called - should be impossible") << endmsg; - /*NOTREACHED*/ + /* nothing to do */ } void MidiPlaylistSource::destroy_model () { - fatal << string_compose (_("programming error: %1"), "MidiPlaylistSource::destroy_model() called - should be impossible") << endmsg; - /*NOTREACHED*/ + /* nothing to do */ } void -- cgit v1.2.3