From ce16b5424fd05a72d1fe086caa3c1dd0a697916b Mon Sep 17 00:00:00 2001 From: Tim Mayberry Date: Sat, 17 Sep 2016 19:20:06 +1000 Subject: Fix crash when ExportDialog is hidden The issue is that when ExportDialog is destroyed ExportFileNotebook::FilePage::on_hide is called which in turn calls ExportProfileManager::save_format_to_disk() in order to save changes to the analysis and soundcloud upload checkboxes. This then causes the ExportProfileManager::FormatListChanged signal to be emitted, which in all other cases is emitted when the format list is modified so that the GUI can rebuild the format selector menu in ExportFormatSelector::update_format_list when a format is added or removed. The problem when doing this in the destructor is that some of the widgets have already been destroyed, specifically the issue was in ExportFileNotebook::update_soundcloud_upload trying to access the soundcloud_selector member that had already had its destructor called. As it is not necessary to call this signal in the first place and it just causes unnecessary GUI updates remove the signal emission. --- libs/ardour/export_profile_manager.cc | 1 - 1 file changed, 1 deletion(-) (limited to 'libs/ardour/export_profile_manager.cc') diff --git a/libs/ardour/export_profile_manager.cc b/libs/ardour/export_profile_manager.cc index 4eb2e62b0b..94099faa26 100644 --- a/libs/ardour/export_profile_manager.cc +++ b/libs/ardour/export_profile_manager.cc @@ -633,7 +633,6 @@ ExportProfileManager::save_format_to_disk (ExportFormatSpecPtr format) tree.write(); } - FormatListChanged (); return new_path; } -- cgit v1.2.3