From 67c75c5a3390d689d716012e9cdf9405bdad988c Mon Sep 17 00:00:00 2001 From: Robin Gareus Date: Thu, 30 Jul 2015 05:28:25 +0200 Subject: fix file metadata tagging on windows. This allows TagLib to open the file and create a Tag object (see 2a0365c) Tagging still fails later (taglib seek/SetFilePointer fails when writing) --- libs/ardour/export_handler.cc | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'libs/ardour/export_handler.cc') diff --git a/libs/ardour/export_handler.cc b/libs/ardour/export_handler.cc index 46cd247d20..04951980d3 100644 --- a/libs/ardour/export_handler.cc +++ b/libs/ardour/export_handler.cc @@ -310,6 +310,13 @@ ExportHandler::finish_timespan () } if (fmt->tag()) { + /* close file first, otherwise TagLib enounters an ERROR_SHARING_VIOLATION + * The process cannot access the file because it is being used. + * + * TODO: check Umlauts and encoding in filename. + * TagLib eventually calls CreateFileA(), + */ + graph_builder->reset (); AudiofileTagger::tag_file(filename, *SessionMetadata::Metadata()); } -- cgit v1.2.3