From b084036c87b57c61eb80a6a4d345b8bf9b0c4857 Mon Sep 17 00:00:00 2001 From: Robin Gareus Date: Fri, 20 Jan 2017 00:33:44 +0100 Subject: Fix oddities when replacing VST-presets. VST used the count of available of presets as URI: - add 2 presets (1,2) - remove first, add another one -> two presets with same URI (2,2) PluginInfo::get_presets() simply lists all (name only) in a vector. Plugin::find_presets() uses the URI in a map (unique by URI). ..various ensuing bugs: eg. Plugin::remove_preset() looked up by name, but didn't check for NULL. --- libs/ardour/ardour/plugin.h | 2 -- 1 file changed, 2 deletions(-) (limited to 'libs/ardour/ardour') diff --git a/libs/ardour/ardour/plugin.h b/libs/ardour/ardour/plugin.h index 374dca82c2..56d19a0cb4 100644 --- a/libs/ardour/ardour/plugin.h +++ b/libs/ardour/ardour/plugin.h @@ -358,8 +358,6 @@ private: /** Fill _presets with our presets */ virtual void find_presets () = 0; - void update_presets (std::string src_unique_id, Plugin* src ); - /** Add state to an existing XMLNode */ virtual void add_state (XMLNode *) const = 0; -- cgit v1.2.3