From 705ac7bfc5cc3e4d793a3c1faa3326d1627679a7 Mon Sep 17 00:00:00 2001 From: Robin Gareus Date: Thu, 23 Apr 2020 02:25:38 +0200 Subject: Prevent huge stack allocations for MIDNAM files xmlParseMemory() uses a c-pointer char*. Previously MIDNAM data on the heap were wrapped inside a std::string only to be later accessed via c_str(). --- libs/ardour/ardour/midi_patch_manager.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'libs/ardour/ardour') diff --git a/libs/ardour/ardour/midi_patch_manager.h b/libs/ardour/ardour/midi_patch_manager.h index 148a946c3a..cb4f492bc4 100644 --- a/libs/ardour/ardour/midi_patch_manager.h +++ b/libs/ardour/ardour/midi_patch_manager.h @@ -64,8 +64,8 @@ public: PBD::Signal0 PatchesChanged; - bool add_custom_midnam (const std::string& id, const std::string& midnam); - bool update_custom_midnam (const std::string& id, const std::string& midnam); + bool add_custom_midnam (const std::string& id, char const*); + bool update_custom_midnam (const std::string& id, char const*); bool remove_custom_midnam (const std::string& id); bool is_custom_model (const std::string& model) const; -- cgit v1.2.3