From 430e51065cbae15ec67ddf78c3b44785d4fd3a9b Mon Sep 17 00:00:00 2001 From: Robin Gareus Date: Fri, 22 Mar 2019 14:12:30 +0100 Subject: Update cAutomationControl values when copying state This fixes a bug that can result in inconsistent session-state when copying plugin state from one plugin to another (via drag/drop ProcessorBox::object_drop, LINK). The underlying plugin state and settings are copied, port _shadow_data is updated, and ::get_parameter() shows the correct new value. However the Controllable was not updated. On Session save/restore the value may have be lost or was inconsistently restored. --- libs/ardour/ardour/plugin_insert.h | 1 + 1 file changed, 1 insertion(+) (limited to 'libs/ardour/ardour') diff --git a/libs/ardour/ardour/plugin_insert.h b/libs/ardour/ardour/plugin_insert.h index 570b48de9a..9e76a9d5bc 100644 --- a/libs/ardour/ardour/plugin_insert.h +++ b/libs/ardour/ardour/plugin_insert.h @@ -396,6 +396,7 @@ private: void control_list_automation_state_changed (Evoral::Parameter, AutoState); void set_parameter_state_2X (const XMLNode& node, int version); void set_control_ids (const XMLNode&, int version); + void update_control_values (const XMLNode&, int version); void enable_changed (); void bypassable_changed (); -- cgit v1.2.3