From a80920c016127d7601bb89ba32c0beb7040c4cdf Mon Sep 17 00:00:00 2001 From: Robin Gareus Date: Tue, 28 Feb 2017 20:08:03 +0100 Subject: Tweak/optimize VST callback: The audioMasterAutomate callback from plugin to host does include the parameter-value. Previously there was a redundant call Plugin::parameter_changed_externally() -> get_parameter -> VSTPlugin::get_parameter() back into the plugin to query the value. calling back into the plugin from the callback, may explain oddities and/or crashes with some VSTs. --- libs/ardour/ardour/vst_plugin.h | 2 ++ 1 file changed, 2 insertions(+) (limited to 'libs/ardour/ardour/vst_plugin.h') diff --git a/libs/ardour/ardour/vst_plugin.h b/libs/ardour/ardour/vst_plugin.h index 00bf680217..f96b35ff4b 100644 --- a/libs/ardour/ardour/vst_plugin.h +++ b/libs/ardour/ardour/vst_plugin.h @@ -40,6 +40,7 @@ class PluginInsert; class LIBARDOUR_API VSTPlugin : public Plugin { public: + friend class Session; VSTPlugin (AudioEngine &, Session &, VSTHandle *); VSTPlugin (const VSTPlugin& other); virtual ~VSTPlugin (); @@ -99,6 +100,7 @@ public: protected: + void parameter_changed_externally (uint32_t which, float val); void set_plugin (AEffect *); gchar* get_chunk (bool) const; int set_chunk (gchar const *, bool); -- cgit v1.2.3