From bd92282cc4f2cd7559e0508222d7f932187b1cf0 Mon Sep 17 00:00:00 2001 From: Paul Davis Date: Wed, 13 Jun 2012 11:55:15 +0000 Subject: flip default value of Plugin::presets_are_MIDI_programs and Plugin::current_preset_uses_general_midi git-svn-id: svn://localhost/ardour2/branches/3.0@12697 d708f5d6-7413-0410-9779-e7cbd77b26cf --- libs/ardour/ardour/plugin.h | 25 ++++++++++++++++++------- 1 file changed, 18 insertions(+), 7 deletions(-) (limited to 'libs/ardour/ardour/plugin.h') diff --git a/libs/ardour/ardour/plugin.h b/libs/ardour/ardour/plugin.h index f33fb9d1e5..15e5f4a9c5 100644 --- a/libs/ardour/ardour/plugin.h +++ b/libs/ardour/ardour/plugin.h @@ -189,14 +189,25 @@ class Plugin : public PBD::StatefulDestructible, public Latent std::vector get_presets (); - /* This is hard to return a correct value for because most plugin APIs - do not specify plugin behaviour. However, if you want to force - the display of plugin built-in preset names rather than MIDI program - numbers, return true. If you want a generic description, return - false. + /** @return true if this plugin will respond to MIDI program + * change messages by changing presets. + * + * This is hard to return a correct value for because most plugin APIs + * do not specify plugin behaviour. However, if you want to force + * the display of plugin built-in preset names rather than MIDI program + * numbers, return true. If you want a generic description, return + * false. */ - virtual bool presets_are_MIDI_programs() const { return true; } - virtual bool current_preset_uses_general_midi() const { return true; } + virtual bool presets_are_MIDI_programs() const { return false; } + + /** @return true if this plugin is General MIDI compliant, false + * otherwise. + * + * It is important to note that it is is almost impossible for a host + * (e.g. Ardour) to determine this for just about any plugin API + * known as of June 2012 + */ + virtual bool current_preset_uses_general_midi() const { return false; } /** @return Last preset to be requested; the settings may have * been changed since; find out with parameter_changed_since_last_preset. -- cgit v1.2.3