From 0b8a7d34291c665edd4b6251394e4f016118cfbb Mon Sep 17 00:00:00 2001
From: Robin Gareus <robin@gareus.org>
Date: Sat, 19 Nov 2016 04:54:36 +0100
Subject: Don't allow recursive calls to EngineDialog

OK -> start_engine() can eg. trigger an interactive plugin scan,
which in turn leaves the EngineDialog responsive. changing settings
or clicking OK again can lead to undefined behavior.
---
 gtk2_ardour/engine_dialog.cc | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

(limited to 'gtk2_ardour/engine_dialog.cc')

diff --git a/gtk2_ardour/engine_dialog.cc b/gtk2_ardour/engine_dialog.cc
index 8a6c42fd8c..b20b56176f 100644
--- a/gtk2_ardour/engine_dialog.cc
+++ b/gtk2_ardour/engine_dialog.cc
@@ -466,10 +466,10 @@ EngineControl::on_response (int response_id)
 
 	switch (response_id) {
 	case RESPONSE_OK:
+		hide();
 		if (!start_engine()) {
+			show();
 			return;
-		} else {
-			hide();
 		}
 #ifdef PLATFORM_WINDOWS
 
-- 
cgit v1.2.3