From 3324c956870c2b0d5eb0759ac1c8ea6f7d853fff Mon Sep 17 00:00:00 2001 From: Robin Gareus Date: Mon, 23 Jul 2018 18:13:41 +0200 Subject: Hardcode pitch-shift algorithm (for now) This fixes an issue with pitch-shift using the most recently used time-stretch algorithm, which may be "resample.." (effective NO-OP). Also leave a ToDo note regarding rubberband crispness levels for later. --- gtk2_ardour/editor_timefx.cc | 26 +++++++++++++++++++++++++- 1 file changed, 25 insertions(+), 1 deletion(-) (limited to 'gtk2_ardour/editor_timefx.cc') diff --git a/gtk2_ardour/editor_timefx.cc b/gtk2_ardour/editor_timefx.cc index 0176f237bb..c623a3fe13 100644 --- a/gtk2_ardour/editor_timefx.cc +++ b/gtk2_ardour/editor_timefx.cc @@ -208,7 +208,31 @@ Editor::time_fx (RegionList& regions, float val, bool pitching) } } - switch (rb_current_opt) { + int rb_mode = rb_current_opt; + + if (pitching /*&& rb_current_opt == 6*/) { + /* The timefx dialog does not show the "stretch_opts_selector" + * when pitch-shifting. So the most recently used option from + * "Time Stretch" would be used (if any). That may even be + * "resample without preserving pitch", which would be invalid. + * + * TODO: also show stretch_opts_selector when pitching (except the option + * to not preserve pitch) and use separate rb_current_opt when pitching. + * + * Actually overhaul this the dialog and processing opts below and use rubberband's + * "Crispness" levels: + * -c 0 equivalent to --no-transients --no-lamination --window-long + * -c 1 equivalent to --detector-soft --no-lamination --window-long (for piano) + * -c 2 equivalent to --no-transients --no-lamination + * -c 3 equivalent to --no-transients + * -c 4 equivalent to --bl-transients + * -c 5 default processing options + * -c 6 equivalent to --no-lamination --window-short (may be good for drums) + */ + rb_mode = 4; + } + + switch (rb_mode) { case 0: transients = NoTransients; peaklock = false; longwin = true; shortwin = false; break; -- cgit v1.2.3