summaryrefslogtreecommitdiff
path: root/gtk2_ardour/editor.cc
AgeCommit message (Collapse)Author
2019-09-29Allow the Cut tool to appear in Mixbus.Ben Loftis
2019-09-25goodbye Profile->...trxPaul Davis
2019-09-18NO-OP: fix some Wimplicit-fallthrough, see prev commitRobin Gareus
2019-08-26Foldback bus should not appear in editorLen Ovens
2019-08-24Consolidate code, skip editor/mixer update checkRobin Gareus
2019-08-24Fix crash when selected automation-lane is removedRobin Gareus
When a plugin is deleted, automation-lanes of the given plugin are removed, but previously a pointed to the deleted lane remained in the selection. This caused crashes later when the track selection is used. e.g. during sensitize_the_right_region_actions() Note that ~TimeAxisView() also emits CatchDeletion (this); however "this" fails to be dynamic_cast<AutomationTimeAxisView*> because that d'tor has already been completed.
2019-08-12Re-order editor sidebar: prioritize "Tracks & Busses"Robin Gareus
2019-08-03Update GPL boilerplate and (C)Robin Gareus
Copyright-holder and year information is extracted from git log. git history begins in 2005. So (C) from 1998..2005 is lost. Also some (C) assignment of commits where the committer didn't use --author.
2019-08-01(Source List) Implement insert-region action... now uses the Source List.Ben Loftis
2019-08-01(Source List) Source list, Region List: Resolve various action+behaviors ↵Ben Loftis
between the 2 lists. Duplicate the remove_unsued_region action in the Session->Cleanup menu, for discoverability. Region list should use the same Region actions as the canvas... OK, now resolve the change in use-cases of Region List and Source List. tentative. Rough-in remove_selected_sources (Delete in Sources list). Column tweaks.
2019-08-01(Source List) Region List rewrite (gtk2 part)Ben Loftis
See: https://docs.google.com/document/d/1sI7p9RoRVZtNx2n67RvBa0_16fuZblV_lNkkKN2g93s/edit?usp=sharing
2019-08-01(Source List) Source property signals (gtk2 part)Ben Loftis
See: https://docs.google.com/document/d/1sI7p9RoRVZtNx2n67RvBa0_16fuZblV_lNkkKN2g93s/edit?usp=sharing
2019-04-09Backport Mixbus toolbutton layoutRobin Gareus
2019-03-29Fix Mixbus special caseRobin Gareus
2019-03-29Fix action-nameRobin Gareus
2019-03-20ActionManager::get_all_actions() no longer includes <Actions> in the paths ↵Paul Davis
it returns, part 3 (GUI)
2019-03-19Add an exception handler for access_action() used by control surfaces and Lua.Ben Loftis
2019-03-19Update GUI, use Session::playlists() getter (2/2)Robin Gareus
2019-03-07Request for comment: Bug or feature?Robin Gareus
2019-03-07Cleanup Editor/Marker context-menuRobin Gareus
This could have caused crashes previously: ::build_range_marker_menu() may have created range_marker_menu while the GUI wanted transport_marker_menu.
2019-03-07Fix some Gtk::Menu related memory leaksRobin Gareus
A Gtk::manage()d widget will be deleted when its parent container is destroyed. Top-level context menus are not inside a container and hence need to be manually deallocated. This adds explicit delete calls for menus where there is a member variable reference to the Menu.
2019-03-07Remove cruft: unused membersRobin Gareus
2019-03-07Remove unused region_edit_menu & edit-point actionRobin Gareus
2019-02-28Initialize per session instant stateRobin Gareus
Per session (instant.xml) GUI options do not have a sigc::slot<> backed configuration interface to initialize the Actions. This fixes a first-time start issue (no instant.xml) where GUI panes may be visible (default) while the actions are "off" (default). This is a tentative solution, instant.xml backed ToggleAction initialization needs to be consolidated somehow.
2018-12-12 replace ::cast_dynamic() with relevant ActionManager::get_*_action() callsPaul Davis
2018-12-11change action group owner pointer to be the relevant keybindings; reorder ↵Paul Davis
setting keybindings value and defining actions The reorder is required so that the value of "bindings" has been set and is meaningful
2018-12-07Remove redundant call (there's no session, nothing to save)Robin Gareus
2018-12-07Fix editor sizing issue introduced in 4dc65e66Robin Gareus
Previously Editor::instant_save() returned if no session was loaded, effectively Config->add_instant_xml(get_state()); was never called. instant save() is called early on, in Editor's c'tor before the editor is realized and saves invalid window-size and window-state, which are used later.
2018-12-06Prefer testing the session instead of using a global variableRobin Gareus
2018-12-05start using ActionMap in preference to ActionManagerPaul Davis
2018-11-11Fix playhead smoothing when auditioning.Robin Gareus
Don't use timer to keep moving the playhead when auditioning. This fixes playhead jiggling during audition.
2018-11-04Save Lua UI scripts separatelyRobin Gareus
Previously EditorAction and ExitorHook scripts were saved with instant.xml. The were saved with each session and in the config dir (for new sessions). This allowed inconsistent UI setups, especially when loading old sessions that had no or different scripts. Now Editor scripts (actions and hooks) are saved in a dedicated file, session-independently. This goes along with ui_config in general e.g. action-table-columns The scripts are not saved with ui_config file for two reasons: ui_config settings related to built-in ui_config_vars.h, and in the future there may be further indirection like "ui-rc-file". Note: previously loaded editor scripts are lost with this change.
2018-08-13Fix missing enum case: Avoid a divide-by-0 crash.Ben Loftis
2018-07-27Allow to disable smart ruler changes.Robin Gareus
2018-07-27NO-OP: clean up whitespace, separate methodsRobin Gareus
2018-07-27new_grid: The Return of the snap_to_X functions.Ben Loftis
We no longer assume that Snap always uses the visible ruler lines. If you want to snap to the grid, and ignore the users zoom scale, use SnapPref::SnapToGrid_Unscaled This fixes 2 (known) oversights: "snap region(s) to grid" and "regions whose start are left of the canvas edge".
2018-07-27new_grid: Add options for rulers_follow_grid and grid_follows_internalBen Loftis
2018-07-23Don't cut-off grid-type.Robin Gareus
Now that the zoom buttons are right-aligned, a variable spaced grid selector is less of an issue (except perhaps on 1024px wide screens)
2018-07-03make use-note-color-for-velocity much much more efficientPaul Davis
(by not invoking the global color change signal)
2018-07-03respond to changes in use-note-color-for-velocityPaul Davis
2018-07-03permit editing velocity bars optionPaul Davis
2018-06-19Revert frame -> sample changes where it's a frame as in Gtk::FrameJohannes Mueller
2018-05-08Replace the check for SnapPref, which went missing. Some functions (like ↵Ben Loftis
playhead_to_next_grid) can request GridOnly.
2018-02-27Reinstate the ability to split regions while dragging playhead. I think ↵Ben Loftis
this was unintentionally lost.
2018-02-26Switch CDFrame grid to use MinSec ruler rather than Sample ruler.Ben Loftis
2018-02-26Rename SMPTE enum back to Timecode.Ben Loftis
2018-02-26Fix a rather large naming thinko: GridTypeSamples should be CDFrames.Ben Loftis
2018-02-24Snap-to-grid should not invalidate other snap options. This was a leftover ↵Ben Loftis
behavior from prior iterations of Snap+Grid.
2018-02-24NO-OP: whitespaceRobin Gareus
- remove trailing whitespace - remove space after opening brackets and before closing brackets - add space around operators - do not use '//' for multi-line comments, do not use "//" on line-start to comment-out code breaking indenting (-Wmisleading-indent) - do add a single space after comment-start /*{SPACE}... or //{SPACE}... - reserve duplicate whitespace " " for alignment, remove other duplicate whitespace - use established "TODO" and "XXX" (highlighted keywords) - remove equal-sign series "====" (those indicate merge conflicts)
2018-02-24Fix/amend a23a8ebcad7.Robin Gareus
Updated condition to check for transport_rolling to include preroll and count-in (speed is != 0 during pre-roll and count-in, but transport is not actually rolling).