diff options
| author | Robin Gareus <robin@gareus.org> | 2016-12-13 23:46:55 +0100 |
|---|---|---|
| committer | Robin Gareus <robin@gareus.org> | 2016-12-13 23:47:07 +0100 |
| commit | fa07233a17036bc1cab69d5854b5c768ff762f5b (patch) | |
| tree | 4048a4a6ca22845a9c80b0ecaf94a453b08b88da /session_utils | |
| parent | 176625d9e0dbe53c9f5628d172ee6f5488be8202 (diff) | |
mutex 'er up
Some overzealous locking to track down RequestObject related crashes.
bc0fa4d689a4 wrongly locked the current event loop's
request_invalidation_lock instead of the invalidation's list lock.
Also Abstract UI is able to delete requests concurrently with with
EventLoop invalidation.
e.g. PortManager::PortRegisteredOrUnregistered and GlobalPortMatrixWindow
so the lock needs to be exposed.
If this solves various issues, mutexes should to be consolidated
(request_buffer_map_lock + request_invalidation_lock) and be chosen
such that there is as little contention as possible.
Diffstat (limited to 'session_utils')
| -rw-r--r-- | session_utils/common.cc | 2 |
1 files changed, 2 insertions, 0 deletions
diff --git a/session_utils/common.cc b/session_utils/common.cc index 8d1cdec950..61a3a69f65 100644 --- a/session_utils/common.cc +++ b/session_utils/common.cc @@ -77,10 +77,12 @@ class MyEventLoop : public sigc::trackable, public EventLoop } Glib::Threads::Mutex& slot_invalidation_mutex() { return request_buffer_map_lock; } + Glib::Threads::Mutex& request_invalidation_mutex() { return request_invalidation_lock; } private: Glib::Threads::Thread* run_loop_thread; Glib::Threads::Mutex request_buffer_map_lock; + Glib::Threads::Mutex request_invalidation_lock; }; static MyEventLoop *event_loop; |