summaryrefslogtreecommitdiff
path: root/scripts
diff options
context:
space:
mode:
authorTim Mayberry <mojofunk@gmail.com>2016-09-17 20:28:34 +1000
committerTim Mayberry <mojofunk@gmail.com>2016-09-17 22:03:16 +1000
commit078889efa89ba2cb4be01108b80861acdc5113cb (patch)
tree2e0368f18a582f2099e1847922a4c923a5d07ae4 /scripts
parentce16b5424fd05a72d1fe086caa3c1dd0a697916b (diff)
Save changes when toggling checkboxes in ExportDialog
I used the Widget::on_hide method in the ExportFileDialog to defer the saving of changes in state of the analysis and soundcloud-upload checkboxes as it was not possible to save the format xml state directly from the ToggleButton::toggled() signal as it created a recursive loop and also to prevent saving the state more than once. Even though the ExportProfileManager::FormatListChanged signal is no longer emitted when saving format state and the crash no longer occurs without this change. I think it is worth saving explicitily from in the toggle callbacks to reduce the complexity of understanding what is taking place and when even if it is less efficient. There is definitely more opportunity for refactoring and redesign.
Diffstat (limited to 'scripts')
0 files changed, 0 insertions, 0 deletions