diff options
| author | Robin Gareus <robin@gareus.org> | 2015-08-17 00:07:32 +0200 |
|---|---|---|
| committer | Robin Gareus <robin@gareus.org> | 2015-08-17 00:07:32 +0200 |
| commit | a46c84d72f7868eba888ac771c182ca8a652f8a3 (patch) | |
| tree | 760c8f94ac26029c5c3196d8fa598c6970a90014 /libs | |
| parent | 2a9dd5d7bbc79b3469d1c57bc6f14e46fcfd1d1a (diff) | |
update comment regarding lv2 buffersizes
Diffstat (limited to 'libs')
| -rw-r--r-- | libs/ardour/lv2_plugin.cc | 9 |
1 files changed, 6 insertions, 3 deletions
diff --git a/libs/ardour/lv2_plugin.cc b/libs/ardour/lv2_plugin.cc index 89a57efa66..62a22bb4dc 100644 --- a/libs/ardour/lv2_plugin.cc +++ b/libs/ardour/lv2_plugin.cc @@ -360,9 +360,12 @@ LV2Plugin::init(const void* c_plugin, framecnt_t rate) LV2_URID atom_Int = _uri_map.uri_to_id(LV2_ATOM__Int); static const int32_t _min_block_length = 1; // may happen during split-cycles static const int32_t _max_block_length = 8192; // max possible (with all engines and during export) - /* @drobilla: Does it make sense to re-instantiate all plugins - * whenever the buffersize changes? - * Is there a way to find plugins that require the min/max blocksize option? + /* Consider updating max-block-size whenever the buffersize changes. + * It requires re-instantiating the plugin (which is a non-realtime operation), + * so it should be done lightly and only for plugins that require it. + * + * given that the block-size can change at any time (split-cycles) ardour currently + * does not support plugins that require bufz_fixedBlockLength. */ LV2_Options_Option options[] = { { LV2_OPTIONS_INSTANCE, 0, _uri_map.uri_to_id(LV2_BUF_SIZE__minBlockLength), |